fix(labware-library): fix ssr hydration bug, module product links, nest lw links, armadillo clone #13083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keep ssr from breaking on rehydration
…st lw links, armadillo clone Fix bug where in the rehydration step of conditionally rendered react children would replace server rendered elements with the wrong client rendered elements. Fix product links to opentrons module pages in nav. Replace all broken nest labware productlinks . duplicate armadillo pcr plate definition in favor of opentrons branded and retire old def Closes RLAB-334, RLAB-330, RLAB-277, RLAB-230
Codecov Report
@@ Coverage Diff @@
## edge #13083 +/- ##
==========================================
+ Coverage 72.20% 72.57% +0.36%
==========================================
Files 1559 2382 +823
Lines 51750 66272 +14522
Branches 3229 7388 +4159
==========================================
+ Hits 37366 48096 +10730
- Misses 13875 16412 +2537
- Partials 509 1764 +1255
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b-cooper
requested review from
SyntaxColoring,
shlokamin and
a team
and removed request for
koji
shared-data/labware/definitions/2/opentrons_96_wellplate_200ul_pcr_full_skirt/2.json
Outdated
Show resolved
Hide resolved
shared-data/labware/definitions/2/opentrons_96_wellplate_200ul_pcr_full_skirt/1.json
Outdated
Show resolved
Hide resolved
..._snapshots/v6.0.1/protocols/55d57ab2-81ed-448d-b24c-3f9c4effd8e3/multipleTipracksWithTC.json
Outdated
Show resolved
Hide resolved
shared-data/labware/definitions/2/nest_1_reservoir_195ml/1.json
Outdated
Show resolved
Hide resolved
SyntaxColoring
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix bug where in the rehydration step of conditionally rendered react children would replace server
rendered elements with the wrong client rendered elements. Fix product links to opentrons module
pages in nav. Replace all broken nest labware product links . duplicate armadillo pcr plate
definition in favor of opentrons branded and retire old def
Closes RLAB-334, RLAB-330, RLAB-277, RLAB-230
Review requests
Risk assessment
med, these changes touch a number of definitions and fixtures across the app