feat(hardware-testing): Configurable plunger acceleration per liquid-class #13038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #13038 +/- ##
==========================================
- Coverage 72.49% 72.04% -0.45%
==========================================
Files 2376 1560 -816
Lines 65595 51223 -14372
Branches 7269 3257 -4012
==========================================
- Hits 47551 36904 -10647
+ Misses 16313 13809 -2504
+ Partials 1731 510 -1221
Flags with carried forward coverage won't be shown. Click here to find out more. |
andySigler
deleted the
feat-hardware-testing-acceleration-in-liquid-class
branch
andySigler
added a commit
that referenced
this pull request
Jul 12, 2023
andySigler
added a commit
that referenced
this pull request
Jul 12, 2023
andySigler
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds plunger acceleration (ul/sec/sec) as one of the configurations that are applied during pipetting motions. This allows the system default accelerations to be used during homing and positioning, and then these faster accelerations can be used during only aspirate/dispense/blow-out movements.
Test Plan
Run 2x trials on the following (make sure they are wet-runs so liquid is actually moved):
Changelog
Review requests
Risk assessment