Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware-testing): Retract farther away from scale #13031

Merged

Conversation

andySigler
Copy link
Contributor

Overview

This PR moves the pipette farther away from the scale during readings to avoid measurement errors from static buildup in the tips and/or labware.

This PR also cleans up the custom labware, so that all custom labware files are located in ./hardware-testing/labware and no where else, and running make push-ot3-gravimetric now pushes all labware to the /data/labware folder on the robot.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested review from a team as code owners June 30, 2023 20:07
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #13031 (a6c00be) into edge (c02954a) will not change coverage.
The diff coverage is n/a.

❗ Current head a6c00be differs from pull request most recent head bff552a. Consider uploading reports for the commit bff552a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13031   +/-   ##
=======================================
  Coverage   72.68%   72.68%           
=======================================
  Files        2367     2367           
  Lines       64641    64641           
  Branches     7266     7266           
=======================================
  Hits        46987    46987           
  Misses      15962    15962           
  Partials     1692     1692           
Flag Coverage Δ
hardware-testing ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@andySigler andySigler merged commit 8f3a979 into edge Jul 3, 2023
5 checks passed
@andySigler andySigler deleted the fix-hardware-testing-retract-farther-away-from-scale branch July 3, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants