Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make push in dependency order #12977

Merged
merged 3 commits into from
Jun 27, 2023
Merged

chore: make push in dependency order #12977

merged 3 commits into from
Jun 27, 2023

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Jun 26, 2023

Overview

Some make push fixes and cleanups.

Test Plan

  • Test this with an OT-2
  • Test this with an OT-3

Changelog

  • When doing a top-level make push or make push-ot3, push things in order from dependencies to dependents. Notably, we need to push server-utils before pushing robot-server and system-server.
  • Fix an apparent bug where make -C notify-server push would restart opentrons-robot-server instead of opentrons-notify-server.
  • Be consistent about restart vs. no-restart choices between the OT-2 and OT-3.

Review requests

Risk assessment

Low. Changes are just to dev tooling.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner June 26, 2023 16:30
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #12977 (3040de0) into edge (7322ac8) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12977      +/-   ##
==========================================
- Coverage   72.87%   72.48%   -0.39%     
==========================================
  Files        2351     1544     -807     
  Lines       64461    50565   -13896     
  Branches     7190     3203    -3987     
==========================================
- Hits        46973    36653   -10320     
+ Misses      15805    13428    -2377     
+ Partials     1683      484    -1199     
Flag Coverage Δ
app 43.88% <ø> (-27.69%) ⬇️
components 66.53% <ø> (ø)
g-code-testing 96.44% <ø> (ø)
hardware 59.18% <ø> (+0.12%) ⬆️
notify-server 89.13% <ø> (ø)
shared-data 76.64% <ø> (+0.01%) ⬆️
system-server 96.07% <ø> (ø)
update-server 65.65% <ø> (ø)
usb-bridge 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 812 files with indirect coverage changes

Copy link
Contributor

@fsinapi fsinapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Makefile Outdated Show resolved Hide resolved
@SyntaxColoring SyntaxColoring merged commit b4e8604 into edge Jun 27, 2023
@SyntaxColoring SyntaxColoring deleted the make_push_dep_order branch June 27, 2023 15:20
TamarZanzouri pushed a commit that referenced this pull request Jun 27, 2023
* Fix notify-server restarting wrong process.

* Use consistent dependency order; push server-utils before robot-server.

* Remove stale todo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants