Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fix thread manager definition #12948

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

pmoegenburg
Copy link
Member

@pmoegenburg pmoegenburg commented Jun 21, 2023

Overview

Attempts to address the following issue:

Hi, we are having the following issue when trying to run calibrate_belts() from ot3repl on DVT-10 robot with [email protected]:
>>> calibrate_belts(OT3Mount.LEFT, "P50SV3420230621A01") Traceback (most recent call last): File "<console>", line 1, in <module> File "/opt/opentrons-robot-server/opentrons/hardware_control/scripts/repl.py", line 102, in synchronizer return asyncio.get_event_loop().run_until_complete( File "/usr/lib/python3.8/asyncio/events.py", line 639, in get_event_loop raise RuntimeError('There is no current event loop in thread %r.' RuntimeError: There is no current event loop in thread 'MainThread'.

Test Plan

  • verify multiple calls of calibrate_belts method call produce accurate results without above error

Changelog

Review requests

Risk assessment

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #12948 (b66869e) into edge (6b09817) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12948   +/-   ##
=======================================
  Coverage   72.91%   72.92%           
=======================================
  Files        2346     2346           
  Lines       64354    64352    -2     
  Branches     7163     7163           
=======================================
  Hits        46926    46926           
+ Misses      15753    15751    -2     
  Partials     1675     1675           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/hardware_control/scripts/repl.py 0.00% <ø> (ø)

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fixes things and passes tests, go for it!

@pmoegenburg pmoegenburg marked this pull request as ready for review July 6, 2023 20:28
@pmoegenburg pmoegenburg requested a review from a team as a code owner July 6, 2023 20:28
@pmoegenburg pmoegenburg self-assigned this Jul 6, 2023
@pmoegenburg pmoegenburg added api Affects the `api` project fix PR fixes a bug labels Jul 6, 2023
@pmoegenburg pmoegenburg merged commit 4635318 into edge Jul 6, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants