Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): change Flex front USB port number to 9 to disambiguate #12923

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

pmoegenburg
Copy link
Member

@pmoegenburg pmoegenburg commented Jun 15, 2023

Overview

The Flex has 1 front USB port. It was previously given port number 1. This changes it to port number 9 to disambiguate it from the first port on the left USB port bank.

This PR also changes simulation and emulation port numbers from 0 so as not to be interpreted as null by layers higher in the stack.

Test Plan

  • verify front USB port displays as 9 in App network/module settings
  • verify USBPort(port=1, hub=false, portGroup="main") for OT-2 simulation
  • verify USBPort(port=1, hub=false, portGroup="left") for Flex simulation

Changelog

Review requests

Risk assessment

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #12923 (0853ec3) into edge (dcb6ace) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12923      +/-   ##
==========================================
- Coverage   73.30%   73.30%   -0.01%     
==========================================
  Files        2324     2324              
  Lines       63708    63706       -2     
  Branches     6984     6984              
==========================================
- Hits        46699    46697       -2     
  Misses      15354    15354              
  Partials     1655     1655              
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/drivers/rpi_drivers/types.py 87.87% <ø> (ø)
api/src/opentrons/hardware_control/api.py 82.47% <ø> (-0.04%) ⬇️
...ardware_control/emulation/module_server/helpers.py 72.41% <ø> (ø)
api/src/opentrons/hardware_control/ot3api.py 80.20% <ø> (-0.06%) ⬇️

@pmoegenburg pmoegenburg self-assigned this Jun 21, 2023
@pmoegenburg pmoegenburg changed the title fix(api): change Flex front USB port number to 9 to disabiguate fix(api): change Flex front USB port number to 9 to disambiguate Jun 21, 2023
@pmoegenburg pmoegenburg marked this pull request as ready for review July 7, 2023 07:18
@pmoegenburg pmoegenburg requested a review from a team as a code owner July 7, 2023 07:18
@pmoegenburg pmoegenburg added api Affects the `api` project fix PR fixes a bug labels Jul 7, 2023
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@pmoegenburg pmoegenburg merged commit 96c4dcf into edge Jul 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants