test(components): remove getByRoles for each button key #12798
Merged
+243
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests for software keyboard used getByRole for each button key and that slows down the tests. This PR removes most getByRole that used for each button key and check key value with getAllByRole and forEach.
Codecov Report
@@ Coverage Diff @@
## edge #12798 +/- ##
=======================================
Coverage 73.50% 73.50%
=======================================
Files 2261 2261
Lines 62047 62047
Branches 6717 6717
=======================================
Hits 45605 45605
Misses 14842 14842
Partials 1600 1600
Flags with carried forward coverage won't be shown. Click here to find out more. |
ewagoner
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
tests for software keyboard used getByRole for each button key and that slows down the tests. This PR removes most getByRole that used for each button key and check key value with getAllByRole and forEach.
before
✓ should render the software keyboards (7348 ms)
after
✓ should render the software keyboards (134 ms)
Test Plan
Changelog
Review requests
Risk assessment
low