Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): emulator proxy client uri logic #12778

Merged
merged 3 commits into from
May 24, 2023
Merged

fix(api): emulator proxy client uri logic #12778

merged 3 commits into from
May 24, 2023

Commits on May 24, 2023

  1. fix: Fix emulator proxy client uri logic 

    - Add `use_local_host` flag to ProxySettings, default to True
- All applications that utilize the proxy directly on the host machine will use localhost.
  - This addresses issues with G-Code tests dying because it cannot resolve the host name
- opentrons-emulation will override this value to `False` in an environment variable cause the host names to be set to the container names. When referencing the container names inside of the docker network these resolve to the internal docker IPs of the emulators.
    Derek Maggio committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7065175 View commit details
    Browse the repository at this point in the history

  2. Formatting and missed import

    Derek Maggio committed May 24, 2023
    Configuration menu
    Copy the full SHA
    63ccbf4 View commit details
    Browse the repository at this point in the history

  3. Add log message

    Derek Maggio committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1461df1 View commit details
    Browse the repository at this point in the history