refactor(discovery-client,app-shell): prefer manual address entries in health poller #12734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n health poller to allow updating existing address entries in the health poller manually, the getAddresses selector and discovery-client health poller are updated to prefer manual address entries closes RCORE-763
Codecov Report
@@ Coverage Diff @@
## edge #12734 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 2264 2264
Lines 61506 61524 +18
Branches 6775 6794 +19
=======================================
+ Hits 45130 45146 +16
+ Misses 14760 14756 -4
- Partials 1616 1622 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
May 22, 2023
| @@ -91,11 +92,12 @@ export function createHealthPoller(options: HealthPollerOptions): HealthPoller { | |||
| // if xor (symmetric difference) returns values, then elements exist in | |||
| // one list and not the other and need to be added to and/or removed from the queue | |||
| // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions | |||
| if (nextList && xorBy(pollQueue, nextList, 'ip').length > 0) { | |||
| if (nextList && xorWith(pollQueue, nextList, isEqual).length > 0) { | |||
There was a problem hiding this comment.
IMO we should stick to set math or boolean math and not mix and match, so is there a lodash disjunction function or something?
There was a problem hiding this comment.
i don't think lodash has a disjunction function, and considers xor to be its version of symmetric difference. we could do a union of differences instead but that's a bit more cumbersome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
to allow updating existing address entries in the health poller manually, the getAddresses selector and discovery-client health poller are updated to prefer manual address entries
closes RCORE-763
Test Plan
Changelog
Review requests
Risk assessment
medium-ish, changes health poller logic