Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): replace 12px with a new spacing #12688

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented May 11, 2023

Overview

replace 12px with a new spacing
padding and margin that use 0.75rem -> SPACING.spacing12

Screenshot 2023-05-11 at 5 41 58 PM

Test Plan

not required

Changelog

  • 0.75rem -> SPACING.spacing12
  • update stories for Spacing

Review requests

Risk assessment

low

replace 12px with a new spacing
@koji koji requested review from a team, ewagoner, b-cooper, shlokamin, smb2268, brenthagen, jerader and jgbowser and removed request for a team May 11, 2023 20:19
@ewagoner
Copy link
Contributor

Approved pending fixing the two missing imports.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #12688 (e832f28) into edge (63b3333) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12688      +/-   ##
==========================================
+ Coverage   73.50%   73.53%   +0.02%     
==========================================
  Files        2281     2282       +1     
  Lines       62665    62834     +169     
  Branches     6706     6780      +74     
==========================================
+ Hits        46065    46204     +139     
- Misses      14999    15011      +12     
- Partials     1601     1619      +18     
Flag Coverage Δ
app 72.05% <80.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/App/Navbar.tsx 90.90% <ø> (ø)
app/src/atoms/InlineNotification/index.tsx 70.00% <ø> (ø)
app/src/atoms/MenuList/MenuItem.tsx 100.00% <ø> (ø)
app/src/atoms/SelectField/Select.tsx 47.61% <ø> (ø)
app/src/atoms/Toast/index.tsx 77.14% <0.00%> (ø)
app/src/atoms/buttons/FloatingActionButton.tsx 100.00% <ø> (ø)
...rc/molecules/WizardRequiredEquipmentList/index.tsx 95.00% <ø> (ø)
app/src/organisms/AnalyticsSettingsModal/index.tsx 33.33% <ø> (ø)
...ckCalibration/ResultsSummary/CalibrationResult.tsx 100.00% <ø> (ø)
...s/CheckCalibration/ResultsSummary/RenderResult.tsx 100.00% <ø> (ø)
... and 28 more

... and 3 files with indirect coverage changes

@koji koji marked this pull request as ready for review May 11, 2023 20:45
@koji koji requested a review from a team as a code owner May 11, 2023 20:45
@koji koji merged commit db9e6c5 into edge May 12, 2023
@koji koji deleted the refactor_apply-to-new-spacing branch May 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants