feat(app): update led lights button in robot settings #12670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update led lights button in robot settings, add tests, and remove dummy components
Codecov Report
@@ Coverage Diff @@
## edge #12670 +/- ##
=======================================
Coverage 73.53% 73.54%
=======================================
Files 2276 2275 -1
Lines 62636 62638 +2
Branches 6694 6699 +5
=======================================
+ Hits 46060 46065 +5
+ Misses 14976 14972 -4
- Partials 1600 1601 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ewagoner
reviewed
May 10, 2023
| }: RobotSettingButtonProps): JSX.Element => { | ||
| const { t } = useTranslation(['app_settings', 'shared']) | ||
| const dispatch = useDispatch<Dispatch>() | ||
|
|
||
| const handleClick = (): void => { | ||
| if (currentOption != null && setCurrentOption != null) { | ||
| setCurrentOption(currentOption) | ||
| } else { | ||
| } else if (Boolean(enabledDevTools)) { |
There was a problem hiding this comment.
Why are you coercing these to Booleans if they're already typed that way?
ewagoner
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update led lights button in robot settings, add tests, and remove dummy components
Screen.Recording.2023-05-09.at.11.04.12.PM.mov
Now RobotSettingsDashboard is beefy. I have a branch that refactored the component. The PR will be opened right after this PR
Test Plan
Changelog
Review requests
Risk assessment
low