feat(app): complete error handling for calibration on Opentrons Flex

[jerader]

closes RLIQ-385

Overview

Previously, when calibrating a pipette, there is erorr handling when attaching the probe. However, there is no way to detach the probe. Now, when you run into that error, it prompts you to detach the probe and then exits the flow.

Test Plan

• test on both desktop app and ODD. Go through calibration, when an error occurs when executing the calibratePipette command, there is now an error modal with information about the error, then prompting the user to hit the next button and then showing the detach probe page. Once you hit "exit calibration", the robot homes and closes the flow. Should be the same for both ODD and desktop.

Changelog

• create error modal CalibrationErrorModal. Change logic in AttachProbe to show modal when there is an error and then clicking on next shows DetachProbe with no back button and proceeds to exit.
• add logic to PipetteWizardFlows to show correct wizard header info when exiting from calibration error
• fix tests

Review requests

see test plan

Risk assessment

low

[jerader]

figured it made sense to not allow users to go back when you run into this error.

[smb2268]

definitely!

[jerader]

Basically, when you reach page 1 of the 2 in the error sequence, the exit button from the wizard header is not rendered, this forces the user to hit next and see the 2nd page where the user is prompted to detach the probe.

[jerader]

I am not sure if this logic is needed? So when you hit errors elsewhere in the flow, the progress bar stays the same as the page you hit the error on. When you reach the DetachProbe page, this is technically step 2 (at least for calibration flowtype) of the flow but since we hit an error, I am making it say current step - 1, so the progress bar does not progress.

[smb2268]

It's a good thought, but let's remove for now to keep the logic as simple as possible and then if something comes up in design QA we can reconsider!

[codecov]

Codecov Report

Merging #12656 (cb9da86) into edge (7b9c8e0) will increase coverage by 0.00%.
The diff coverage is 81.81%.

@@           Coverage Diff           @@
##             edge   #12656   +/-   ##
=======================================
  Coverage   73.54%   73.55%           
=======================================
  Files        2282     2283    +1     
  Lines       62672    62682   +10     
  Branches     6711     6718    +7     
=======================================
+ Hits        46095    46103    +8     
  Misses      14977    14977           
- Partials     1600     1602    +2     

Flag	Coverage Δ
app	72.12% <81.81%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...p/src/organisms/PipetteWizardFlows/AttachProbe.tsx	85.71% <ø> (ø)
app/src/organisms/PipetteWizardFlows/index.tsx	64.64% <60.00%> (-0.62%)	⬇️
...nisms/PipetteWizardFlows/CalibrationErrorModal.tsx	100.00% <100.00%> (ø)
...p/src/organisms/PipetteWizardFlows/DetachProbe.tsx	100.00% <100.00%> (ø)

[jerader]

@ecormany, thoughts on what the modal should say? The one attached in this pr. The modal pops up if you run into an error when attaching the calibration probe. The subheader is the error string. What should the header say?

[smb2268]

Tested this out and it looks great!

[ecormany]

The subheader is the error string. What should the header say?

I think we can keep it simple: Pipette calibration failed

This PR may not address it, but the subheader should give context like Detach the probe from the pipette and try calibrating again.