Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): robotWorkSpace remove classnames add transform #12649

Merged
merged 2 commits into from
May 5, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented May 5, 2023

closes RQA-746

Overview

The deck map rendered in PD should not be upside down, neither should the deckmaps/labware anywhere (such as in labware library)

Test Plan

  • in PD make sure that the deck map is not rendered upside down

Changelog

  • remove usage of classNames in RobotWorkSpace to only use styled components, fix affected components and remove unnecessary css style sheets

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner May 5, 2023 19:05
@jerader jerader requested review from brenthagen, b-cooper and a team and removed request for a team and brenthagen May 5, 2023 19:05
@jerader jerader requested a review from shlokamin May 5, 2023 19:11
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #12649 (0a296a6) into edge (548744f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12649      +/-   ##
==========================================
+ Coverage   73.57%   73.59%   +0.02%     
==========================================
  Files        2273     2273              
  Lines       62584    62692     +108     
  Branches     6656     6712      +56     
==========================================
+ Hits        46046    46139      +93     
- Misses      14952    14956       +4     
- Partials     1586     1597      +11     
Flag Coverage Δ
app 72.27% <ø> (+0.10%) ⬆️
components 67.97% <ø> (ø)
labware-library 49.74% <ø> (ø)
protocol-designer 46.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/src/hardware-sim/Deck/RobotWorkSpace.tsx 0.00% <ø> (ø)
...ware-library/src/components/labware-ui/Gallery.tsx 0.00% <ø> (ø)
...ol-designer/src/components/DeckSetup/DeckSetup.tsx 28.23% <ø> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🦖 . Thanks for doing this

@jerader jerader merged commit b19b507 into edge May 5, 2023
@jerader jerader deleted the pd_rotate-deck-map-180deg branch May 5, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants