Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Enable --strict-markers in all pytest configurations #12596

Merged
merged 1 commit into from
May 1, 2023

Conversation

SyntaxColoring
Copy link
Contributor

Overview

While working on RLAB-256, I got confused by a silly mistake where I misspelled a pytest mark, like pytest.mark.ot3only instead of pytest.mark.ot3_only.

It turns out that there's an option to prevent this, --strict-markers, and it's easy to enable in all of our Python projects. This PR does that.

Test Plan

Make sure CI keeps passing.

Review requests

Is there any reason not to do this?

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring added chore python General Python tickets and PRs; e.g. tech debt or Python guild activities labels Apr 28, 2023
@SyntaxColoring SyntaxColoring requested review from a team as code owners April 28, 2023 19:53
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #12596 (c285395) into edge (bb34bd7) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #12596      +/-   ##
==========================================
- Coverage   73.59%   73.57%   -0.03%     
==========================================
  Files        2267     2267              
  Lines       62341    62370      +29     
  Branches     6592     6602      +10     
==========================================
+ Hits        45881    45886       +5     
- Misses      14886    14910      +24     
  Partials     1574     1574              
Flag Coverage Δ
app 72.10% <ø> (-0.13%) ⬇️
g-code-testing 96.44% <ø> (-0.08%) ⬇️
hardware 58.66% <ø> (+<0.01%) ⬆️
notify-server 89.13% <ø> (ø)
protocol-designer 46.34% <ø> (ø)
shared-data 75.35% <ø> (ø)
step-generation 88.20% <ø> (ø)
system-server 96.07% <ø> (ø)
update-server 65.65% <ø> (ø)
usb-bridge 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@SyntaxColoring
Copy link
Contributor Author

I'll be out until May 4. If this gets an approval from someone, feel free to merge it in my absence.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfoster1 sfoster1 merged commit b14ce90 into edge May 1, 2023
@sfoster1 sfoster1 deleted the strict_markers_everywhere branch May 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore python General Python tickets and PRs; e.g. tech debt or Python guild activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants