Protocol designer OT-3 development #12540
Conversation
…signer-Landing-Page
…signer-Landing-Page
…signer-Landing-Page
* Landing Page Initial Commit * Round Tabs implementation
…signer-Landing-Page
…' of https://github.com/Opentrons/opentrons into pd_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
…-flex-pipette-selection
Revert pipette selection component as previous commit
…-flex-pipette-selection
…' of https://github.com/Opentrons/opentrons into pd-flex-pipette-selection
…pentrons into pd-flex-pipette-selection
…_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
…_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
…_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
…_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
2. Conditional css changes done
This reverts commit 73ab5aa.
There was a problem hiding this comment.
I left some questions about why things are commented out. If you are going to use something in a follow up PR that is currently commented out, please leave a short comment describing what the purpose of it is, that makes it easier to review.
Additionally, the changes made to the labware-defs/utils affects OT2 PD. We should keep OT2 PD functionality the same. Probably the best solution is to modify the util to work for both OT2 and OT3
| // const [customTipRackPropsUpdated, setCustomTipRackProps] = useState( | ||
| // customTipRackProps | ||
| // ) | ||
| // useEffect(() => { | ||
| // setCustomTipRackProps(customTipRackProps) | ||
| // }, [customTipRackProps]) |
There was a problem hiding this comment.
Yes. In the next pull request, all irrelevant code or non-essential elements will be removed.
protocol-designer/src/components/FlexProtocolEditor/FlexPillForm/TipRackList.tsx
Show resolved
Hide resolved
| import * as React from 'react' | ||
| import { ProtocolEditor } from './ProtocolEditor' | ||
|
|
||
| import React from 'react' |
There was a problem hiding this comment.
is there a reason why the react import statement needed to be changed here?
There was a problem hiding this comment.
I will revert the change in this component since it is not necessary.
…_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
…' of https://github.com/Opentrons/opentrons into pd_dev_RPLC-225-RPLC-384-Protocol-Designer-Landing-Page
Overview
• Landing page added with three buttons.
• Implement pipette and tip rack selection based on the Figma design.
• Implement nav pill form according to the Figma design.
• Create new routes based on the Figma design.
• Note: this is ongoing development
Implementation details
• Implement routing for the new routes using React Router.
• OT-2 Button navigates previous OT-2 platform.
• Create appropriate route components and configure routing paths.
• Added new components for form data collection.
• Added new components for pipette and tip rack selection.
• For the nav pill form state management Formik state management and props
• Added new components for the nav pill form.
• Showing dynamic module selection (not added gripper and trash chute)
• Dynamic Pipette selection and design changes.
• Pipette validation
• Import OT2 and OT3 files
• file details page for the new OT3 json.
• Navigate to liquid page functionality on module selection.
Test Plan
Working on JSON creations, right now unable to test.
Changelog
• Implement routing for the new routes using React Router.
• OT-2 Button navigates previous OT-2 platform.
• Create appropriate route components and configure routing paths.
• Added new components for form data collection.
• Added new components for pipette and tip rack selection.
• For the nav pill form state management Formik state management and props
• Added new components for the nav pill form.
• Showing dynamic module selection (not added gripper and trash chute)
• Dynamic Pipette selection and design changes.
• Pipette validation
• Import OT2 and OT3 files
• file details page for the new OT3 json.
• Navigate to liquid page functionality on module selection.
Review requests
Risk assessment
Medium: module selection development is ongoing and OT3 JSON creation not completed yet.
• OT3 file edit functionality is InProgress.
• Ot2 and OT3 supported tip rack differentiation InProgress.