Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ODD): HiFi designs and features for the protocol details page #12330

Merged
merged 25 commits into from
Mar 28, 2023
Merged

feat(ODD): HiFi designs and features for the protocol details page #12330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ee347d3
Use new tabbede buttons for navigation [RCORE-684]
ewagoner Mar 16, 2023
a3d5e57
Added medium button hifi component [RCORE-684]
ewagoner Mar 20, 2023
985e0b2
Add icon to medium buttons [RCORE-684]
ewagoner Mar 20, 2023
fb4a6ef
Add new 'Start setup' text [RCORE-684]
ewagoner Mar 21, 2023
3c8a491
Removed unnecessary medium rounded button component [RCORE-684]
ewagoner Mar 21, 2023
d5e3ca5
Improve linting on LargeButton component [RCORE-684]
ewagoner Mar 21, 2023
da6e48f
Add new typography for protocol header [RCORE-684]
ewagoner Mar 21, 2023
8fc6238
Set max number of pins as an app constant [RCORE-684]
ewagoner Mar 21, 2023
76cdf07
Generalize Too Many Pins modal [RCORE-684]
ewagoner Mar 21, 2023
384991e
Apply HiFi stylings to Too Many Pins Modal ORCORE-684]
ewagoner Mar 21, 2023
9cd661c
Added back chevron icon svg [RCORE-684]
ewagoner Mar 21, 2023
69e672e
Added optional width to medium buttons [RCORE-684]
ewagoner Mar 21, 2023
ec7901e
Protocol details page hifi design [RCORE-684]
ewagoner Mar 21, 2023
2ca0e44
Hardware and Labware hifi styling [RCORE-684]
ewagoner Mar 21, 2023
ea946f2
Fixed case of Chip import [RCORE-684]
ewagoner Mar 21, 2023
8775c18
Fixed TooManyPins storybook name [RCORE-684]
ewagoner Mar 21, 2023
7ba2748
Added unit tests for core protocol details odd page [RCORE-684]
ewagoner Mar 21, 2023
c28ed86
Made date/time test timezone independent [RCORE-684]
ewagoner Mar 22, 2023
d79030b
Naming and code style changes from PR feedback. No logic changes. [RC…
ewagoner Mar 23, 2023
7e14e77
Moved the TooManyPins modal into its forever home [RCORE-684]
ewagoner Mar 23, 2023
5f3d30f
Removed box shadow from TabbedButton focus state [RCORE-684]
ewagoner Mar 23, 2023
97a3521
Increase test coverage for nav buttons [RAUT-684]
ewagoner Mar 23, 2023
b1ea6da
Changed MediumButton and TabbedButton to use Btn as their base compon…
ewagoner Mar 23, 2023
a33fb8e
Adjusted spacing to match final designs. Added TODO comments. [RAUT-684]
ewagoner Mar 23, 2023
23ab256
Minor spacing tweaks [RCORE-684]
ewagoner Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added back chevron icon svg [RCORE-684]
  • Loading branch information
@ewagoner
ewagoner committed Mar 28, 2023
commit 9cd661c8828d0c26bb79e7852231498e1bda156d
24 changes: 24 additions & 0 deletions components/src/__tests__/__snapshots__/icons.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,30 @@ exports[`icons arrow-right renders correctly 1`] = `
</svg>
`;

exports[`icons back renders correctly 1`] = `
.c0.spin {
-webkit-animation: GLFYz 0.8s steps(8) infinite;
animation: GLFYz 0.8s steps(8) infinite;
-webkit-transform-origin: center;
-ms-transform-origin: center;
transform-origin: center;
}

<svg
aria-hidden="true"
className=" c0 foo"
fill="currentColor"
version="1.1"
viewBox="0 0 19 34"
xmlns="http:https://www.w3.org/2000/svg"
>
<path
d="M16.6667 33.6668L0 17.0002L16.6667 0.333496L19 2.7085L4.70833 17.0002L19 31.2918L16.6667 33.6668Z"
fillRule="evenodd"
/>
</svg>
`;

exports[`icons book-open-page-variant renders correctly 1`] = `
.c0.spin {
-webkit-animation: GLFYz 0.8s steps(8) infinite;
Expand Down
5 changes: 5 additions & 0 deletions components/src/icons/icon-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ export const ICON_DATA_BY_NAME = {
path:
'M4,11V13H16L10.5,18.5L11.92,19.92L19.84,12L11.92,4.08L10.5,5.5L16,11H4Z',
},
back: {
viewBox: '0 0 19 34',
path:
'M16.6667 33.6668L0 17.0002L16.6667 0.333496L19 2.7085L4.70833 17.0002L19 31.2918L16.6667 33.6668Z',
},
ewagoner marked this conversation as resolved.
Show resolved Hide resolved
circle: {
viewBox: '0 0 24 24',
path:
Expand Down