-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): Allow aspirate, dispense and blow-out in place in PE and PAPI #12105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
TamarZanzouri
added
the
robot-svcs
Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
label
Feb 6, 2023
Codecov Report
@@ Coverage Diff @@
## edge #12105 +/- ##
==========================================
- Coverage 74.02% 73.76% -0.26%
==========================================
Files 2172 1458 -714
Lines 59816 48132 -11684
Branches 6104 2994 -3110
==========================================
- Hits 44278 35504 -8774
+ Misses 14174 12173 -2001
+ Partials 1364 455 -909
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TamarZanzouri
commented
Feb 7, 2023
TamarZanzouri
commented
Feb 7, 2023
api/src/opentrons/protocol_engine/commands/aspirate_in_place.py
Outdated
Show resolved
Hide resolved
TamarZanzouri
commented
Feb 7, 2023
api/src/opentrons/protocol_engine/commands/aspirate_in_place.py
Outdated
Show resolved
Hide resolved
TamarZanzouri
commented
Feb 7, 2023
api/src/opentrons/protocol_engine/commands/blow_out_in_place.py
Outdated
Show resolved
Hide resolved
TamarZanzouri
commented
Feb 7, 2023
Tested the aspirate-in-place and dispense-in-place on an OT2 with core ff on. will test blow-out-in-place |
TamarZanzouri
changed the title
refactor(api): Allow aspirate, dispense and blow-out in place
refactor(api): Allow aspirate, dispense and blow-out in place in PE and PAPI
Feb 7, 2023
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
…ore.py Co-authored-by: Mike Cousins <[email protected]>
…ore.py Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
…ument_context.py Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
…ore.py Co-authored-by: Mike Cousins <[email protected]>
…ore.py Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
Co-authored-by: Mike Cousins <[email protected]>
mcous
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
robot-svcs
Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://opentrons.atlassian.net/browse/RCORE-540.
Allow PE and PAPI via engine core to preform aspirate, dispense and blow-out in place.
Test Plan
Test on an OT-2 with core ff on or on an OT-3.
upload the following protocol:
Changelog
instrumnt_context
and added a method to return wether we are passing a Well or a Location to the core's.Review requests
Does the changes make sense?
Did I forget anything for the PE commands?
Risk assessment
Low. Should act the same as the legacy papi. Should test with core ff on and off to make sure it behaves the same