Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(makefile): do not push ODD app by default #12022

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Jan 18, 2023

Overview

The hardware + embedded folks are reporting that they don't need to push the app to the OT-3, and that it's annoying to have the app included as part of the top level push command because it takes the most time.

This PR just removes the app from being pushed to the OT-3 by default. If folks want to push the ODD app to an OT-3, they can run the push-ot3 make command from the app-shell-odd directory.

Risk assessment

Low

@shlokamin shlokamin requested a review from a team as a code owner January 18, 2023 20:42
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #12022 (a3b9149) into edge (28b7bc0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12022   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files        2187     2187           
  Lines       60500    60500           
  Branches     6401     6401           
=======================================
  Hits        44825    44825           
  Misses      14141    14141           
  Partials     1534     1534           
Flag Coverage Δ
app 72.55% <ø> (ø)
components 65.28% <ø> (ø)
g-code-testing 97.19% <ø> (ø)
hardware 57.31% <ø> (ø)
hardware-testing ∅ <ø> (∅)
notify-server 89.13% <ø> (ø)
shared-data 85.48% <ø> (ø)
system-server 0.00% <ø> (ø)
update-server 65.47% <ø> (ø)
usb-bridge 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vegano1
Copy link
Contributor

vegano1 commented Jan 18, 2023

LGTM!
Tested on ot3 with the following cases, all are working.

  • make push-ot3 host=<ip-addr>
  • make -C app-shell-odd push-ot3 host=<ip-addr>
  • cd app-shell-odd && make push-ot3 host=<ip-addr>

@shlokamin shlokamin merged commit bd8a3f0 into edge Jan 19, 2023
@shlokamin shlokamin deleted the chore_do-not-push-odd-by-default branch January 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants