Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(monorepo): do not run linter on compiled files #11964

Merged
merged 2 commits into from
Jan 9, 2023
Merged

build(monorepo): do not run linter on compiled files #11964

merged 2 commits into from
Jan 9, 2023

Conversation

shlokamin
Copy link
Member

Overview

This PR prevents the linter from running on transpiled JS from the app-shell-odd

Changelog

  • Do not lint transpiled JS from app-shell-odd

Risk assessment

Low

@shlokamin shlokamin requested a review from a team as a code owner January 9, 2023 16:24
@shlokamin shlokamin changed the title build(monorepo): do not run on app-shell-odd transpiled JS build(monorepo): do not run linter on app-shell-odd transpiled JS Jan 9, 2023
sfoster1
sfoster1 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not have this be **/lib/**/*?

@shlokamin
Copy link
Member Author

Is there a reason to not have this be /lib//*?

Not that I can think of... I'll do that

@shlokamin shlokamin changed the title build(monorepo): do not run linter on app-shell-odd transpiled JS build(monorepo): do not run linter on compiled files Jan 9, 2023
@shlokamin shlokamin merged commit 045bc72 into edge Jan 9, 2023
@shlokamin shlokamin deleted the eslint_ignore-app-shell-odd-lib branch January 9, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@brenthagen brenthagen brenthagen approved these changes

@koji koji Awaiting requested review from koji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlokamin @sfoster1 @brenthagen