Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware): parallel mcu fw update capability #11948

Merged
merged 8 commits into from
Jan 23, 2023

Conversation

pmoegenburg
Copy link
Member

@pmoegenburg pmoegenburg commented Jan 4, 2023

Overview

Currently, the run_update method is used to update the firmware for each robot microcontroller serially. This PR adds a run_updates method (and script) to update microcontroller firmwares in parallel.

Test Plan

  • Ensure two separate microcontrollers' firmwares are successfully updated serially with one initial run_updates method call from the update_fws.py script. Total time 99sec for 2 microcontrollers.
  • Ensure two separate microcontrollers' firmwares are successfully updated simultaneously with one next-iteration run_updates method call from the update_fws.py script. Total time 60sec for 2 microcontrollers.

Changelog

  • Added simultaneous updating of robot subsystem microcontroller firmware

Review requests

Risk assessment

Low. This builds off of the existing and proven serial updating process with proven software components.

@pmoegenburg pmoegenburg requested a review from a team as a code owner January 4, 2023 21:20
@pmoegenburg pmoegenburg self-assigned this Jan 4, 2023
@pmoegenburg pmoegenburg requested a review from a team as a code owner January 4, 2023 21:20
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #11948 (eb50c34) into edge (1f67b59) will decrease coverage by 0.05%.
The diff coverage is 13.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11948      +/-   ##
==========================================
- Coverage   74.04%   73.99%   -0.05%     
==========================================
  Files        2184     2184              
  Lines       60340    60406      +66     
  Branches     6334     6334              
==========================================
+ Hits        44678    44697      +19     
- Misses      14162    14209      +47     
  Partials     1500     1500              
Flag Coverage Δ
hardware 56.88% <13.46%> (-0.43%) ⬇️
notify-server 89.13% <ø> (ø)
system-server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hardware/opentrons_hardware/scripts/update_fws.py 0.00% <0.00%> (ø)
...are/opentrons_hardware/firmware_update/__init__.py 100.00% <100.00%> (ø)
hardware/opentrons_hardware/firmware_update/run.py 100.00% <100.00%> (ø)
...hardware/hardware_control/motor_position_status.py 52.00% <0.00%> (-2.17%) ⬇️
...rons_hardware/firmware_bindings/messages/fields.py 52.71% <0.00%> (-1.39%) ⬇️
...ons_hardware/hardware_control/move_group_runner.py 82.64% <0.00%> (-0.13%) ⬇️
shared-data/js/constants.ts 100.00% <0.00%> (ø)
.../opentrons_hardware/firmware_bindings/constants.py 100.00% <0.00%> (ø)
system-server/system_server/__main__.py
...ns_hardware/firmware_bindings/messages/payloads.py 99.15% <0.00%> (+<0.01%) ⬆️

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, but let's get the PR description a little more information before merging.

DEV_SETUP.md Outdated Show resolved Hide resolved
Co-authored-by: Seth Foster <[email protected]>
@pmoegenburg pmoegenburg merged commit 10a5334 into edge Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants