Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): currentOffsetModal only displays latest offsets #11913

Merged
merged 9 commits into from
Jan 10, 2023
Merged

refactor(app): currentOffsetModal only displays latest offsets #11913

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
facb5cf
refactor(app): currentOffsetModal only displays latest offsets
jerader Dec 20, 2022
af030f3
create useLPCDisabledReason
jerader Dec 20, 2022
e9b9bd9
fix util and add test cases
jerader Dec 20, 2022
4bc0b4c
fix SetupLabware test
jerader Dec 21, 2022
026ff49
rename ao to currentLabwareOffsets
jerader Dec 21, 2022
3cf9ca5
filter out identity offsets after deduping
b-cooper Jan 9, 2023
e1bbd6c
remove redundant labware position check modal
b-cooper Jan 9, 2023
42becb0
test fixup
b-cooper Jan 9, 2023
982a108
lint
b-cooper Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
filter out identity offsets after deduping
  • Loading branch information
@b-cooper
b-cooper committed Jan 9, 2023
commit 3cf9ca52510a172dafe333194bdfa2d683aea328
12 changes: 6 additions & 6 deletions app/src/organisms/Devices/ProtocolRun/SetupLabware/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,7 @@ export function getLabwareSetupItemGroups(
export function getLatestCurrentOffsets(
currentOffsets: LabwareOffset[]
): LabwareOffset[] {
const nonIdentityOffsets = currentOffsets.filter(
currentOffset => !isEqual(currentOffset.vector, IDENTITY_VECTOR)
)

const latestCurrentOffsets = nonIdentityOffsets.reduce<LabwareOffset[]>(
const latestCurrentOffsets = currentOffsets.reduce<LabwareOffset[]>(
(acc, offset) => {
const previousMatchIndex = acc.findIndex(
currentLabwareOffsets =>
Expand All @@ -118,5 +114,9 @@ export function getLatestCurrentOffsets(
[]
)

return latestCurrentOffsets
const nonIdentityOffsets = latestCurrentOffsets.filter(
currentOffset => !isEqual(currentOffset.vector, IDENTITY_VECTOR)
)

return nonIdentityOffsets
}