feat(hardware): increase firmware update speed #11898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Dec 15, 2022
Codecov Report
@@ Coverage Diff @@
## edge #11898 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 2141 2141
Lines 58674 58676 +2
Branches 6294 6294
=======================================
+ Hits 43399 43401 +2
Misses 13795 13795
Partials 1480 1480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, thread management issues resulted in intermittent delays during the firmware update process. This PR introduces an isolated ThreadPoolExecutor that eliminates these issues. As verified on an OT3, update time drops from roughly 100s to roughly 50s.
First improvement found during RCORE-288 ticket work.