refactor(shared-data): Remove OT-2 calibration points from OT-3 deck def #11816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #11816 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 2107 2107
Lines 58695 58695
Branches 6226 6226
=======================================
Hits 43525 43525
Misses 13703 13703
Partials 1467 1467
Flags with carried forward coverage won't be shown. Click here to find out more. |
y3rsh
added a commit
that referenced
this pull request
Dec 5, 2022
* origin/edge: feat(app): add new config value to store sortKey for protocols (#11787) fix(app-shell): dispatch DOWNLOAD_LOGS_DONE when download cancelled (#11798) refactor(shared-data): Remove OT-2 calibration points from OT-3 deck def (#11816) docs(api): clarify Thermocycler GEN2 plate lift feature (#11817) refactor(api): add homing commands to engine cores (#11805) add a labware dropped error (#11814) feature(hardware): broadcast a stop message when a critical error is detected (#11813) feature(hardware): refactor hardware controller to watch for valid responses and error messages (#11789) fix(app): pick up tip from last tip rack in LPC if heater shaker is loaded into 1 or 3 (#11796) refactor(labware-library): update test guide links (#11809) fix(engine): home gripper z when not using virtual gripper (#11811)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The OT-3 deck definition describes a bunch of calibration points. These points don't actually physically exist on the OT-3, though. They appear to be an accidental carryover from the OT-2 deck definition.
Changelog
Remove all calibration points from the OT-3's deck definition.
Risk assessment
Low if all of the tests keep passing.