feat(app): add UI to each modal step in ot-3 pipette cal #11626
Conversation
| @@ -29,7 +29,7 @@ export function WizardRequiredEquipmentList( | |||
| const { equipmentList, footer } = props | |||
|
|
|||
| return ( | |||
| <Flex flexDirection={DIRECTION_COLUMN}> | |||
| <Flex flexDirection={DIRECTION_COLUMN} width="100%"> | |||
There was a problem hiding this comment.
Is this width="100%" really what we'll want in every place that this component might be rendered? "Yes" might be an acceptable answer, though I'd lean towards having this component's props extend StyleProps that an instance of this component can spread whatever StyleProps it wants into the outer most container for specific layout purposes.
| @@ -71,7 +71,7 @@ export const PipetteOverflowMenu = ( | |||
| </MenuItem> | |||
| ) : ( | |||
| <> | |||
| {!isOT3PipetteAttached && ( | |||
| { | |||
There was a problem hiding this comment.
looks like these curly-braces are gratuitous now
| CALIBRATE: 'CALIBRATE', | ||
| } | ||
|
|
||
| export const CALIBRATION_PROBE_DISPLAYNAME = 'Calibration Probe' |
There was a problem hiding this comment.
nit: display name is two words elsewhere in the codebase. That would make this const CALIBRATION_PROBE_DISPLAY_NAME
|
TODO: address this comment after that PR merges. |
8d3d0f7
to
6ec3bb4
Compare
Codecov Report
@@ Coverage Diff @@
## edge #11626 +/- ##
==========================================
+ Coverage 74.58% 74.60% +0.01%
==========================================
Files 2074 2074
Lines 57827 57854 +27
Branches 6104 6112 +8
==========================================
+ Hits 43133 43162 +29
Misses 13265 13265
+ Partials 1429 1427 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
closes RLIQ-227 RLIQ-223 RLIQ-221
Blocked to merge until #11618 merges
Overview
Add the UI to each step modal in the ot-3 pipette calibration flow:
BeforeBeginning,AttachStem,DetachStem,Results. Only adds the UI aspects so nothing is really wired up yet.Changelog
BeforeBeginning,AttachStem,DetachStem,Results, updates testsPipetteWizardStepPropsto includegoBackprop.subHeaderprop optional inSimpleWizardBodyGenericWizardTileequipmentImagesGenericWizardTilerelated components (story and test)Review requests
Calibrate pipette offsetbutton in the overflow menu. Click through the flow. There should be 4 pages and they should each more or less follow the figma designs. The main things that aren't very finalized are the attach/detach stem images.Risk assessment
low