feat(api, robot-server): Allow loadLiquid commands and liquids support in protocol engine and analysis #11310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamarZanzouri
added
the
robot-svcs
Codecov Report
@@ Coverage Diff @@
## edge #11310 +/- ##
=======================================
Coverage 74.53% 74.53%
=======================================
Files 2033 2033
Lines 56588 56588
Branches 5437 5437
=======================================
Hits 42180 42180
Misses 13180 13180
Partials 1228 1228
Flags with carried forward coverage won't be shown. Click here to find out more.
|
TamarZanzouri
commented
Aug 18, 2022
TamarZanzouri
commented
Aug 18, 2022
| assert result == LoadLiquidResult() | ||
|
|
||
|
|
||
| async def test_load_liquid_liquid_not_found( |
There was a problem hiding this comment.
are these tests redundant now that the logic lives in the state?
There was a problem hiding this comment.
maybe delete these test
TamarZanzouri
commented
Aug 19, 2022
TamarZanzouri
commented
Aug 19, 2022
…liquid.py. changed has method name
TamarZanzouri
commented
Aug 19, 2022
TamarZanzouri
commented
Aug 19, 2022
| """Get all protocol liquids.""" | ||
| return list(self._state.liquids_by_id.values()) | ||
|
|
||
| def validate_has_liquid(self, liquid_id: str) -> str: |
There was a problem hiding this comment.
same comment ^
Laura-Danielle
approved these changes
Aug 19, 2022
mcous
reviewed
Aug 22, 2022
api/tests/opentrons/protocol_engine/commands/test_load_liquid.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Cousins <[email protected]>
|
Tested on a robot with json v5 and v6 protocols |
mcous
approved these changes
Aug 23, 2022
sfoster1
pushed a commit
that referenced
this pull request
Oct 21, 2022
…t in protocol engine and analysis (#11310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes Jira ticket RLIQ-8.
this PR gives protocol engine the ability to consume and analyze loadLiquid and store liquids in the engine state.
Changelog
Review requests
Risk assessment
Medium. Added a new command, should not effect if not being called. added Liquids to StateSummery and Run data models. need to make sure old logic is not effected.