Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): h-S troubleshooting guide links to correct pages #11196

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jul 21, 2022

Overview

The order of H-S Wizard pages changed a few weeks ago to put the PowerOn page before the AttachAdapter page. This PR fixes the troubleshooting guide buttons and text to accommodate that change that was previously forgotten about.

Changelog

  • make changes to TestShake, i18n key, and the test file

Review requests

  • the heater shaker wizard test Shake troubleshooting guide should link to the correct pages when you click on the buttons

Risk assessment

low

@jerader jerader requested a review from a team as a code owner July 21, 2022 17:47
@jerader jerader requested review from smb2268, sakibh, shlokamin and a team and removed request for a team and smb2268 July 21, 2022 17:47
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #11196 (15fc31e) into edge (18ed237) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11196      +/-   ##
==========================================
+ Coverage   73.82%   73.89%   +0.06%     
==========================================
  Files        2085     2086       +1     
  Lines       57715    58155     +440     
  Branches     5853     6078     +225     
==========================================
+ Hits        42610    42974     +364     
- Misses      13818    13862      +44     
- Partials     1287     1319      +32     
Flag Coverage Δ
app 71.71% <0.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...organisms/Devices/HeaterShakerWizard/TestShake.tsx 71.18% <0.00%> (+2.76%) ⬆️
...Devices/RobotSettings/AdvancedTab/FactoryReset.tsx 88.88% <0.00%> (-11.12%) ⬇️
...ces/RobotSettings/AdvancedTab/DisplayRobotName.tsx 88.88% <0.00%> (-11.12%) ⬇️
...librationDetails/PipetteOffsetCalibrationItems.tsx 72.72% <0.00%> (-8.53%) ⬇️
...tup/HeaterShakerSetupWizard/HeaterShakerBanner.tsx 60.00% <0.00%> (-6.67%) ⬇️
...s/CalibrationDetails/TipLengthCalibrationItems.tsx 80.00% <0.00%> (-6.37%) ⬇️
app/src/organisms/Devices/PipettesAndModules.tsx 62.06% <0.00%> (-6.36%) ⬇️
...src/organisms/Devices/ProtocolRun/SetupModules.tsx 82.50% <0.00%> (-3.71%) ⬇️
...src/organisms/Devices/HeaterShakerWizard/index.tsx 78.18% <0.00%> (-2.26%) ⬇️
...ms/Devices/RobotSettings/RobotSettingsAdvanced.tsx 52.63% <0.00%> (-1.72%) ⬇️
... and 28 more

@jerader jerader requested review from vabruzzo and koji July 26, 2022 14:03
Copy link
Contributor

@sakibh sakibh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jerader jerader merged commit 0c9530e into edge Jul 26, 2022
@jerader jerader deleted the app_hs-troubleshoot-test-shake-bug-fix branch July 26, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants