fix(app): labware setup H-S latch command add runId #11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
vabruzzo,
sakibh and
shlokamin
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #11133 +/- ##
=======================================
Coverage 73.62% 73.63%
=======================================
Files 2085 2085
Lines 57593 57593
Branches 5741 5741
=======================================
+ Hits 42404 42408 +4
+ Misses 13951 13949 -2
+ Partials 1238 1236 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sakibh
approved these changes
Jul 14, 2022
| @@ -113,7 +116,8 @@ const ModuleExtraAttentionItem = ( | |||
| } | |||
|
|
|||
| const toggleLatch = (): void => { | |||
There was a problem hiding this comment.
You can also use the useLatchControls hook where it now can take in an optional runId for controls that have a run associated with them. It returns a toggleLatch function as well. Although, this will require passing in the AttachedModule as the first parameter.
There was a problem hiding this comment.
yeah, i tried using useLatchControls initially but was having a hard time getting HeaterShakerAttachedModule, so not using it was the cleanest way I think. But I can look into it more!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11048 & #11125
Overview
The labware setup extra attention banner for the H-S has a button that allows you to open/close the latch. However, the latch command didn't include the runId which is required to send commands to modules during setup.
Changelog
runIdinModuleExtraAttentionand fix testReview requests
Risk assessment
low