Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): h-S overflow menu tooltip visibility #11115

Closed
wants to merge 2 commits into from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jul 13, 2022

closes #11043

Overview

This fixes the tooltip logic for the h-s overflow menu. Now, when the latch is opened and the shaker button is disabled, the tooltip only shows up for the shake button.

Changelog

  • changed logic in ModuleOverflowMenu so the tooltip props are only added to the menu button that is disabled
  • removed unnecessary react fragment

Review requests

  • for the H-S card, when your latch is opened and the shake button is disabled, hover over the disabled button. there should be a tooltip. Hover over the set temp button, there should not be a tooltip.

Risk assessment

low

@jerader jerader requested a review from a team as a code owner July 13, 2022 13:23
@jerader jerader requested review from b-cooper, shlokamin and sakibh and removed request for a team July 13, 2022 13:23
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #11115 (6739395) into edge (d7e5d73) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11115      +/-   ##
==========================================
- Coverage   73.62%   73.62%   -0.01%     
==========================================
  Files        2085     2085              
  Lines       57593    57595       +2     
  Branches     5741     5742       +1     
==========================================
  Hits        42404    42404              
- Misses      13951    13952       +1     
- Partials     1238     1239       +1     
Flag Coverage Δ
app 70.88% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pp/src/organisms/ModuleCard/ModuleOverflowMenu.tsx 84.61% <100.00%> (-15.39%) ⬇️

@jerader
Copy link
Collaborator Author

jerader commented Jul 14, 2022

Set shake slideout and overflow menu button is being removed in the updated designs so the tooltip will be removed too: #11074

@jerader jerader closed this Jul 14, 2022
@jerader jerader deleted the app_hs-overlfow-menu-tooltip-placement branch July 14, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.0 Feedback: Tooltip for heater shaker overflow menu is not in correct spot
1 participant