feat(api): Forbid Heater-Shakers in slot 9, just south of the trash #11019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a check to Python Protocol API v2's
.load_module()
method to prevent you from loading a Heater-Shaker into slot 9, because it would conflict with the fixed trash in "slot" 12.Closes #10912.
Review requests
_get_adjacent_locations()
and friends to make sure I'm correctly preserving their existing behavior.# TODO
comment somewhere for mirroring this logic in PAPIv3 or Protocol Engine?Risk assessment
Low.
This change involved refactoring some unrelated deck conflict-checking code, so there is some risk of causing
load_module()
orload_labware()
to either wrongly fail to report a conflict or wrongly report a nonexistent conflict. But this module seems covered well by unit and integration tests.