Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): protocol Run Record protocolName no longer renders runId #10961

Merged

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 30, 2022

closes #10899 closes #10658

Overview

This fixes the bug where the runid renders in the protocol name section. Now, if protocolName and protocol file are still rendering, Loading... will be in place

Changelog

  • change RecentProtocolRun and test
  • remove unnecessary fetching that I previously added because I thought it fixed this bug

Review requests

  • run a few protocols to get a protocol run record. Refresh the app, the protocol name should say "Loading..." instead of runId

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 30, 2022 16:15
@jerader jerader requested review from shlokamin, vabruzzo, brenthagen, b-cooper, koji and a team and removed request for a team June 30, 2022 16:15
const isRobotViewable = useIsRobotViewable(robotName)
const [dispatchRequest, requestIds] = useDispatchApiRequest()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously added this useDispatchApiRequest to fetch protocols when I initially tackled ticket 10658. I thought it fixed the bug but it didn't. So deleting it now.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #10961 (f9c529a) into release_6.0.0 (5d775be) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release_6.0.0   #10961   +/-   ##
==============================================
  Coverage          73.75%   73.75%           
==============================================
  Files               2081     2081           
  Lines              57522    57515    -7     
  Branches            5795     5793    -2     
==============================================
- Hits               42427    42422    -5     
+ Misses             13820    13819    -1     
+ Partials            1275     1274    -1     
Flag Coverage Δ
app 70.95% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/organisms/Devices/RecentProtocolRuns.tsx 76.47% <50.00%> (+1.47%) ⬆️

@jerader jerader removed request for shlokamin and a team June 30, 2022 16:21
Copy link
Contributor

@vabruzzo vabruzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm 👍

@jerader jerader merged commit 322c71c into release_6.0.0 Jun 30, 2022
@jerader jerader deleted the app_recent-protocol-runs-protocol-name-bug-fix branch June 30, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants