Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pd): Remove google-fonts-webpack-plugin #1093

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Mar 26, 2018

overview

The API that backs the google-fonts-webpack-plugin is down as at the time of writing and breaking our builds. This PR removes the plugin from the PD build pipeline in favor of just using fonts.google.com to get our builds back to green.

We can reevaluate how we want to handle webfonts with PD once @IanLondon is back.

changelog

  • build(pd): Remove google-fonts-webpack-plugin

review requests

Please ensure make -C protocol-designer dev and make -C protocol-designer build still run on your machine, and that there's no font-based regressions between edge's build and this branch's build

@mcous mcous added chore ready for review fix PR fixes a bug protocol designer Affects the `protocol-designer` project labels Mar 26, 2018
@mcous mcous requested review from Kadee80 and IanLondon March 26, 2018 01:24
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #1093 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #1093   +/-   ##
=======================================
  Coverage   50.23%   50.23%           
=======================================
  Files         198      198           
  Lines        3446     3446           
  Branches      392      392           
=======================================
  Hits         1731     1731           
  Misses       1618     1618           
  Partials       97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d19e8...0faf1e5. Read the comment docs.

@Laura-Danielle Laura-Danielle self-requested a review March 26, 2018 12:34
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕

@mcous mcous merged commit 693285a into edge Mar 26, 2018
@mcous mcous deleted the pd_remove-google-fonts-wp-plugin branch March 26, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore fix PR fixes a bug protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants