Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): if robot is not connectable during run, navigate to devices #10769

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 15, 2022

closes #10584

Overview

When you are running a protocol and turn off the robot/lose connection to robot/robot is not CONNECTABLE, the app should redirect to the devices page

Changelog

  • add useIsRobotViewable to ProtocolRunHeader and fix test

Review requests

  • upload a protocol (you can start or not start it), turn off your robot. The app should navigate to the devices page rather than staying on the protocol run page

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 15, 2022 15:11
@jerader jerader requested review from aptrons22, vabruzzo, b-cooper and koji and removed request for a team June 15, 2022 15:11
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #10769 (9bbc7bd) into release_6.0.0 (66be913) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release_6.0.0   #10769      +/-   ##
=================================================
- Coverage          73.83%   73.83%   -0.01%     
=================================================
  Files               2158     2158              
  Lines              58340    58344       +4     
  Branches            5959     5961       +2     
=================================================
+ Hits               43078    43080       +2     
- Misses             13989    13990       +1     
- Partials            1273     1274       +1     
Flag Coverage Δ
app 71.59% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rganisms/Devices/ProtocolRun/ProtocolRunHeader.tsx 87.30% <60.00%> (-1.23%) ⬇️

Copy link
Contributor

@vabruzzo vabruzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good and works as expected

@jerader jerader merged commit a4123d3 into release_6.0.0 Jun 17, 2022
@jerader jerader deleted the app_robot-lost-connection-direct-to-devices branch June 17, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants