style(app): app_fixed_spacing_for_calibration_modals

[aptrons22]

Overview

Corrected branch issue, removed code from DirectionControl.tsx and refactored the spacing calibration modals code to reside in the JogControls component instead.

#10677

Changelog

Refactored the following files to include marginBottom spacing set to marginBottom={SPACING.spacing5}

• MeasureNozzle.tsx
• MeasureTip.tsx
• SaveXYPoint.tsx
• SaveZPoint.tsx
• TipPickUp.tsx

Review requests

Low

Risk assessment

Low

[codecov]

Codecov Report

Merging #10766 (f8a4a05) into release_6.0.0 (f88a416) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           release_6.0.0   #10766      +/-   ##
=================================================
- Coverage          73.84%   73.83%   -0.01%     
=================================================
  Files               2158     2158              
  Lines              58341    58340       -1     
  Branches            5960     5959       -1     
=================================================
- Hits               43079    43078       -1     
  Misses             13989    13989              
  Partials            1273     1273              

Flag	Coverage Δ
app	71.59% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/src/molecules/JogControls/DirectionControl.tsx	85.71% <ø> (ø)
app/src/molecules/JogControls/index.tsx	100.00% <ø> (ø)
.../src/organisms/CalibrationPanels/MeasureNozzle.tsx	70.96% <ø> (ø)
app/src/organisms/CalibrationPanels/MeasureTip.tsx	66.66% <ø> (ø)
...pp/src/organisms/CalibrationPanels/SaveXYPoint.tsx	79.59% <ø> (ø)
app/src/organisms/CalibrationPanels/SaveZPoint.tsx	97.36% <ø> (ø)
app/src/organisms/CalibrationPanels/TipPickUp.tsx	87.50% <ø> (ø)
...isms/Devices/ModuleCard/MagneticModuleSlideout.tsx	90.00% <0.00%> (-0.25%)	⬇️

[jerader]

The changes look good, the only thing is now that you are merging into release_6.0.0, you should see the marginBottom={SPACING.spacing5} reflected in JogControls. After you remove that, this PR should be good to go 🚀

[jerader]

This looks good to me! 🚀 We may want design approval from Mel when she gets back next week before merging though.

[vabruzzo]

looks good 👍

[b-cooper]

This fix looks good. When Mel is back in town, we'll also want to get her approval on the visuals.

[koji]

The changes look good to me.
You are not replacing any old SPACING_s. Is there any specific reason?