-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App fix protocols landing design feedback #10741
Closed
aptrons22
wants to merge
23
commits into
release_6.0.0
from
app_fix-protocols-landing-design-feedback
Closed
App fix protocols landing design feedback #10741
aptrons22
wants to merge
23
commits into
release_6.0.0
from
app_fix-protocols-landing-design-feedback
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made several styling updates to the protocol landing page. #10488
…l landing page added new/revised styling for the protocol landing page #10488
…n link revised the spacing and added opacity to API documentation link #10488
…tates fixed a few app design changes fonts, spacing and added states #10488
fixed the label in EmptyStateLinks.tsx #10488
fixed merge conflict #10488
resolved issues with linting #10488
Codecov Report
@@ Coverage Diff @@
## release_6.0.0 #10741 +/- ##
=================================================
+ Coverage 73.84% 74.06% +0.22%
=================================================
Files 2158 2147 -11
Lines 58341 57458 -883
Branches 5961 5935 -26
=================================================
- Hits 43079 42556 -523
+ Misses 13989 13630 -359
+ Partials 1273 1272 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR will fix #10488
darkGreyEnabled
darkGreyEnabled
darkGreyEnabled
. No uppercase herep-semibold
, currently it's boldlabel-semibold
styling.Changelog
Review requests
Low
Risk assessment
Low