Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App fix protocols landing design feedback #10741

Closed

Conversation

aptrons22
Copy link
Contributor

Overview

The PR will fix #10488

  • (1) Missing the enabled state (no fill background), and needs a hover state linked up.
  • (2) Remove the white fill from the button
  • (3) When I press on the button, i get the orange outline. The orange outline is only the focus state and should only appear when a user tabs through all the links using 'tab' on their keyboard. So remove this please! (Already Done)
  • (4) update 'sort by' text to our darkGreyEnabled
  • (5) Looks like we're missing the hover state for the protocol cards. Check the design system for info
  • (7) Update this text across all cards to our darkGreyEnabled
  • (8) The columns should have a min-width of 170px so regardless of what content is in them, the columns will always align. These columns should be responsive when the user shrinks the viewport.
  • (9) Update both of these so it's our label text in darkGreyEnabled. No uppercase here
  • (10) Update text should align to the bottom of the other containers to the left.
  • (11) Update to be our p-semibold, currently it's bold
  • (12) Update to our label-semibold styling.
  • (13) Double check the colour of the text and the icon. They should be the same
  • (14) Update the spacing here between header and text below to .25 rem

Screen Shot 2022-06-06 at 2 02 01 PM

Changelog

  • The following list above has been completed.
  • Styling of icons has been modified
  • Styling of text colors
  • Icon behaviors has been revised

Review requests

Low

Risk assessment

Low

I made several styling updates to the protocol landing page.

#10488
…l landing page

added new/revised styling for the protocol landing page

#10488
…n link

revised the spacing and added opacity to API documentation link

#10488
…tates

fixed a few app design changes fonts, spacing and added states

#10488
fixed the label in EmptyStateLinks.tsx

#10488
resolved issues with linting

#10488
@aptrons22 aptrons22 changed the base branch from edge to release_6.0.0 June 13, 2022 21:21
@aptrons22 aptrons22 self-assigned this Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #10741 (acfde42) into release_6.0.0 (70cb3cb) will increase coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release_6.0.0   #10741      +/-   ##
=================================================
+ Coverage          73.84%   74.06%   +0.22%     
=================================================
  Files               2158     2147      -11     
  Lines              58341    57458     -883     
  Branches            5961     5935      -26     
=================================================
- Hits               43079    42556     -523     
+ Misses             13989    13630     -359     
+ Partials            1273     1272       -1     
Flag Coverage Δ
app 71.53% <0.00%> (-0.07%) ⬇️
components 52.78% <ø> (ø)
hardware-testing ?
labware-library 49.74% <ø> (ø)
protocol-designer 45.67% <ø> (ø)
react-api-client 83.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/atoms/buttons/index.tsx 100.00% <ø> (ø)
...src/organisms/ProtocolsLanding/EmptyStateLinks.tsx 100.00% <ø> (ø)
...pp/src/organisms/ProtocolsLanding/ProtocolCard.tsx 0.00% <ø> (ø)
...pp/src/organisms/ProtocolsLanding/ProtocolList.tsx 0.00% <0.00%> (ø)
components/src/primitives/Btn.tsx 100.00% <ø> (ø)
components/src/ui-style-constants/typography.ts 100.00% <ø> (ø)
...rc/commandCreators/atomic/heaterShakerOpenLatch.ts 50.00% <0.00%> (-35.72%) ⬇️
shared-data/js/helpers/index.ts 56.89% <0.00%> (-19.69%) ⬇️
...ices/ProtocolRun/SetupLiquids/getMockLiquidData.ts 7.69% <0.00%> (-5.65%) ⬇️
...data/python/opentrons_shared_data/deck/__init__.py 85.71% <0.00%> (-1.79%) ⬇️
... and 70 more

@koji koji deleted the branch release_6.0.0 June 13, 2022 23:53
@koji koji closed this Jun 13, 2022
@koji koji reopened this Jun 13, 2022
@koji koji closed this Jun 13, 2022
@koji koji reopened this Jun 13, 2022
@aptrons22 aptrons22 closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants