Modified the global default viewport size for the app back to the original size #10579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## edge #10579 +/- ##
==========================================
- Coverage 73.83% 73.82% -0.01%
==========================================
Files 2141 2146 +5
Lines 57638 57944 +306
Branches 5848 5953 +105
==========================================
+ Hits 42555 42780 +225
- Misses 13846 13902 +56
- Partials 1237 1262 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aptrons22
changed the title
aptrons22
changed the title
b-cooper
reviewed
Jun 2, 2022
| ui: { | ||
| ...MOCK_CONFIG_V7.ui, | ||
| width: 1024, | ||
| minWidth: 600, |
There was a problem hiding this comment.
this line is unnecessary as minWidth from v7 is already set to 600
There was a problem hiding this comment.
Thanks for the feedback I have made all of the corrections. Now ready for review.
b-cooper
reviewed
Jun 2, 2022
app-shell/src/config/migrate.ts
Outdated
| ui: { | ||
| ...prevConfig.ui, | ||
| width: 1024, | ||
| minWidth: 600, |
There was a problem hiding this comment.
same comment here about not including the minWidth in this migration as it's left unchanged
b-cooper
reviewed
Jun 2, 2022
app/src/redux/config/schema-types.ts
Outdated
Comment on lines
141
to
143
| ui: ConfigV7['ui'] & { | ||
| minWidth: number | ||
| } |
There was a problem hiding this comment.
the ui key is unchanged between v7 and v8, so these three lines should be unnecessary
vabruzzo
reviewed
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
I have added V8 configuration details for the default app size to be the original size.
Closes #10513
Changelog:
Edited default app window width and height in V8 config migration
Review requests:
In the app you will see the original default app size.
Risk assessment:
Low