feat(app): change H-S set shake speed button disabled reason #10421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
shlokamin and
sakibh
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #10421 +/- ##
==========================================
+ Coverage 73.62% 73.64% +0.01%
==========================================
Files 2134 2134
Lines 57353 57513 +160
Branches 5750 5815 +65
==========================================
+ Hits 42229 42353 +124
- Misses 13923 13946 +23
- Partials 1201 1214 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sakibh
approved these changes
May 31, 2022
| @@ -311,7 +311,8 @@ export function useModuleOverflowMenu( | |||
| disabledReason: | |||
| module.moduleType === HEATERSHAKER_MODULE_TYPE && | |||
| (module.data.labwareLatchStatus === 'idle_open' || | |||
| module.data.labwareLatchStatus === 'opening'), | |||
| module.data.labwareLatchStatus === 'opening' || | |||
| module.data.labwareLatchStatus === 'idle_unknown'), | |||
There was a problem hiding this comment.
Makes sense to add idle_unknown since it is a status that also indicates if the latch has failed to open/close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10418
Overview
This PR changes the disabled reason for the Set Shake Speed button in the H-S overflow menu. Now, when you first launch the app and the labware latch is
idle_unknown, the button is disabled until you close the latch.Also increased the height of the module cards in the
Pipettes and Modules sectionso when the H-S "too hot to touch" banner is enabled, the cards don't overflow into a 3rd columnChangelog
pipettesAndModulesModuleOverflowMenuReview requests
opened, theSet shake speedbutton should always be disabled. When hovering over the button, there should be a tooltip.Risk assessment
low, hs