refactor(app): heater-shaker in app design changes #10366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
shlokamin,
sakibh and
howisthisnamenottakenyet
and removed request for
a team and
shlokamin
Codecov Report
@@ Coverage Diff @@
## edge #10366 +/- ##
==========================================
- Coverage 73.98% 73.98% -0.01%
==========================================
Files 2133 2133
Lines 56900 56917 +17
Branches 5751 5762 +11
==========================================
+ Hits 42097 42109 +12
- Misses 13602 13603 +1
- Partials 1201 1205 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sakibh
approved these changes
May 20, 2022
There was a problem hiding this comment.
Awesome work! Looks good to me. Thanks for adding test coverage for HeaterShakerModuleCard. Just a few small things below not introduced in this PR.
- In the
Introductioncomponent of the heater shaker wizard, the third item shows the display name asHeater-Shaker Module. It should beHeater-Shaker Module GEN1. We can also usegetModuleDisplayNamejust like in theHeaterShakerModuleCardcomponent might have to expose the module model as a prop. - In the
AttachModulecomponent, for the second item it looks like counterclockwise is one word not two, completely my fault.
jerader
force-pushed
the
app_hs-wizard-copy-pass-1
branch
from
8a5da9e
to
3ae9be8
Compare
howisthisnamenottakenyet
suggested changes
May 23, 2022
There was a problem hiding this comment.
A couple more copy changes, an svg flip, a question about image quality, and some button interactivity. Took screenshots and added comments here. https://www.figma.com/file/695ogls23YsQYImRcGYDE1/Heater-Shaker?node-id=4727%3A92660
howisthisnamenottakenyet
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9530 #9779
Overview
This PR makes various UI changes to the H-S set up wizard and the modals to match figma.
Changelog
Review requests
Go through the H-S setup wizard both with a protocol uploaded and with a protocol not uploaded. Do the pages match the designs?
Open the H-S shaker slideout and send a shaking command, a modal should pop up - Does the H-S confirm attachment modal match designs?
Risk assessment
low, behind ff and h-s