Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): fix duplicate i18n key in device details #10120

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 28, 2022

Overview

In edge, i noticed that there was a duplicate i18n key caused by a PR i merged this morning, i corrected it here.

Changelog

  • rename one of the an_error_occurred_while_updating key names

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 28, 2022 15:16
@jerader jerader requested review from aptrons22, sakibh and shlokamin and removed request for a team and aptrons22 April 28, 2022 15:16
@jerader jerader changed the title refactor(app): fix duplicate i18n name refactor(app): fix duplicate i18n key Apr 28, 2022
@jerader jerader changed the title refactor(app): fix duplicate i18n key refactor(app): fix duplicate i18n key in device details Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #10120 (e7d00d4) into edge (19d9180) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #10120   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files        2115     2115           
  Lines       55540    55547    +7     
  Branches     5661     5664    +3     
=======================================
+ Hits        41534    41541    +7     
  Misses      12864    12864           
  Partials     1142     1142           
Flag Coverage Δ
app 71.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Devices/ModuleCard/FirmwareUpdateFailedModal.tsx 100.00% <ø> (ø)
app/src/organisms/Devices/PipettesAndModules.tsx 100.00% <0.00%> (ø)

@jerader jerader merged commit cc9e2a9 into edge Apr 28, 2022
@jerader jerader deleted the app_fix-dublicate-i18n branch April 28, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants