Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(hardware): replace pytest-aiohttp with pytest-asyncio #10022

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

amitlissack
Copy link
Contributor

@amitlissack amitlissack commented Apr 20, 2022

Overview

Just like #10012 and #9981 we should replace pytest-aiohttp with pytest-asyncio. It's faster.

Changelog

  • replace pytest-aiohttp with pytest-asyncio
  • remove loop fixture usage
  • lint

Review requests

  • Tested locally included integration tests using sim_sock_can

Risk assessment

None

@amitlissack amitlissack added the Robot Tech Debt For review in robot guild meetings label Apr 20, 2022
@amitlissack amitlissack requested review from a team and removed request for a team April 20, 2022 13:28
@amitlissack amitlissack requested a review from a team as a code owner April 20, 2022 13:28
@amitlissack amitlissack requested a review from a team as a code owner April 20, 2022 13:28
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #10022 (a384f2c) into edge (81544ba) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #10022   +/-   ##
=======================================
  Coverage   75.00%   75.01%           
=======================================
  Files        2086     2086           
  Lines       54977    54977           
  Branches     5568     5568           
=======================================
+ Hits        41234    41239    +5     
+ Misses      12631    12626    -5     
  Partials     1112     1112           
Flag Coverage Δ
hardware 65.41% <ø> (+0.16%) ⬆️
notify-server 89.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...are/hardware_control/motion_planning/move_utils.py 91.44% <0.00%> (+1.60%) ⬆️
...e/hardware_control/motion_planning/move_manager.py 93.61% <0.00%> (+4.25%) ⬆️

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me, and running make -C hardware test works. 🧪 I'm not sure how make test-with-emulator works, so I couldn't verify that.

@amitlissack
Copy link
Contributor Author

Code changes make sense to me, and running make -C hardware test works. 🧪 I'm not sure how make test-with-emulator works, so I couldn't verify that.

I verified make test-with-emulator. It requires either ot3 docker emulation or locally running firmware and virtual CAN network,

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented Apr 20, 2022

Looks like there's a hanging test:

Wed, 20 Apr 2022 13:41:21 GMT  tests/opentrons/hardware_control/test_poller.py ......                   [ 33%]
Wed, 20 Apr 2022 14:02:36 GMT  Error: The operation was canceled.

😬

@amitlissack
Copy link
Contributor Author

Looks like there's a hanging test:

Wed, 20 Apr 2022 13:41:21 GMT  tests/opentrons/hardware_control/test_poller.py ......                   [ 33%]
Wed, 20 Apr 2022 14:02:36 GMT  Error: The operation was canceled.

😬

I am merging this PR, because the hanging test issue is in api not hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Robot Tech Debt For review in robot guild meetings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants