draft #10000
Closed
draft #10000
+302
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #10000 +/- ##
==========================================
+ Coverage 74.74% 74.75% +0.01%
==========================================
Files 2110 2110
Lines 55429 55470 +41
Branches 5630 5630
==========================================
+ Hits 41429 41466 +37
- Misses 12866 12870 +4
Partials 1134 1134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
requested changes
Apr 20, 2022
| @@ -146,6 +146,9 @@ class MoveCompletedPayload(MoveGroupResponsePayload): | |||
| ack_id: utils.UInt8Field | |||
|
|
|||
|
|
|||
| # maybe write a set sync message | |||
There was a problem hiding this comment.
what would a set sync message be?
| ), | ||
| ) | ||
|
|
||
| while True: |
There was a problem hiding this comment.
Definitely don't want to do this like this:
- shouldn't have a function that has an infinite loop with no break condition - there should always be something.
- lines 87 to 94 will lock this program - this is an async function and
read()is a synchronous call, so the loop won't be able to spin.
| ) | ||
|
|
||
| while True: | ||
| read_data = self.read( |
There was a problem hiding this comment.
oh actually that second thing might just be that this needs to be an await self.read(... but the first thing is true
| node_id=node_id, | ||
| message=BindSensorOutputRequest( | ||
| payload=BindSensorOutputRequestPayload( | ||
| sensor=SensorTypeField(SensorType.capacitive), |
| node_id=node_id, | ||
| message=BaselineSensorRequest( | ||
| payload=BaselineSensorRequestPayload( | ||
| sensor=SensorTypeField(SensorType.capacitive), |
| @classmethod | ||
| def build(cls, data): # type: ignore[no-untyped-def] | ||
| """Build function for sensor data type.""" | ||
| if isinstance(data, list): | ||
| backing = Int32Field(cls._convert_to_int(data)) | ||
| elif isinstance(data, Int32Field): | ||
| # breakpoint() |
caila-marashaj
force-pushed
the
RET-907-sensor-binding-drivers
branch
from
592b7d6
to
dc23391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft pr for sync binding function and tests
also number 10000 WOOOOO 🍾🍾🍾🍾
🎉🎉🎉 🎊🎊
🎉🎉🎉🎉🎊