Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small PD Touch Ups: Darker outline on selected path icon #9658

Closed
anthonywilleee opened this issue Mar 8, 2022 · 0 comments · Fixed by #9663
Closed

Small PD Touch Ups: Darker outline on selected path icon #9658

anthonywilleee opened this issue Mar 8, 2022 · 0 comments · Fixed by #9663
Assignees
@jerader
Labels
protocol designer Affects the `protocol-designer` project

Comments

@anthonywilleee
Copy link

anthonywilleee commented Mar 8, 2022 •
edited
Loading

Overview

This ticket adds a darker outline boosted to 1.5 px on the selected path icon in the transfer step. This makes it clearer for user to know exactly what is selected for transfer path.

Implementation Details

  • Add 1.5 px black border to selected path icon in Transfer step.
  • The icon being highlighted should change when the user's selection changes
  • All other aspects (outside of the border) should remain the same - including size, background color, icon, and selection enabled/disabled conditions

Design Links

Acceptance Criteria

  • 1.5px black border exists on the user's path selection in the transfer step
  • The selected path highlight updates with the 1.5px border if the user changes selection
@anthonywilleee anthonywilleee added the protocol designer Affects the `protocol-designer` project label Mar 8, 2022
@anthonywilleee anthonywilleee changed the title Small PD Touch Ups: Small PD Touch Ups: Darker outline on selected path icon Mar 8, 2022
@jerader jerader self-assigned this Mar 9, 2022
jerader added a commit that referenced this issue Mar 9, 2022
@jerader
refactor(protocol-designer): change selected path icon border
ed239f7 
closes #9658
@jerader jerader mentioned this issue Mar 9, 2022
Merged
jerader added a commit that referenced this issue Mar 11, 2022
@jerader
refactor(protocol-designer): change selected path icon border (#9663)
23187a0 
closes #9658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerader jerader

Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(protocol-designer): change selected path icon border Opentrons/opentrons
2 participants
@jerader @anthonywilleee