Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out interaction between HardwareAPI and new engine-based cancellation logic #8980

Closed
brenthagen opened this issue Dec 3, 2021 · 0 comments · Fixed by #8993
Closed

Sort out interaction between HardwareAPI and new engine-based cancellation logic #8980

brenthagen opened this issue Dec 3, 2021 · 0 comments · Fixed by #8993
Assignees
@mcous
Labels
bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@brenthagen
Copy link
Contributor

Current behavior: a successful stop action during a protocol run triggers a 'failed' status and 'CancelledError' in the run record
@brenthagen brenthagen added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Dec 3, 2021
@brenthagen brenthagen changed the title Sort out interaction between HardwareAPI cancellation logic and new engine-based cancellation logic Sort out interaction between HardwareAPI and new engine-based cancellation logic Dec 3, 2021
mcous added a commit that referenced this issue Dec 6, 2021
@mcous
refactor(engine): do not run redundant cleanup on asyncio.CancelledError
b590281 
Closes #8980
@mcous mcous mentioned this issue Dec 6, 2021
Merged
mcous added a commit that referenced this issue Dec 7, 2021
@mcous
refactor(engine): do not run redundant cleanup on asyncio.CancelledEr…
fec85cd 
…ror (#8993)

Closes #8980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcous mcous

Labels
bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(engine): do not run redundant cleanup on asyncio.CancelledError Opentrons/opentrons
3 participants
@mcous @SyntaxColoring @brenthagen