feat(api): Forbid Heater-Shakers in slot 9, just south of the trash #11019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
added
api
SyntaxColoring
commented
Jul 6, 2022
Comment on lines
+230
to
+232
| # `item` is inconsistently provided to us as an AbstractLabware or Labware. | ||
| # See TODO comments in opentrons.protocols.geometry.deck, | ||
| # the module that calls into this module. |
There was a problem hiding this comment.
@mcous I think you looked into this when you wrote this module originally. Is this a fair summary?
There was a problem hiding this comment.
Yes it is. In practice, it will be a Labware when running a Python protocol, and AbstractLabware when running a JSON protocol
Codecov Report
@@ Coverage Diff @@
## edge #11019 +/- ##
=======================================
Coverage 73.78% 73.78%
=======================================
Files 2076 2076
Lines 57328 57328
Branches 5727 5727
=======================================
Hits 42300 42300
Misses 13789 13789
Partials 1239 1239
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mcous
approved these changes
Jul 6, 2022
Comment on lines
+230
to
+232
| # `item` is inconsistently provided to us as an AbstractLabware or Labware. | ||
| # See TODO comments in opentrons.protocols.geometry.deck, | ||
| # the module that calls into this module. |
There was a problem hiding this comment.
Yes it is. In practice, it will be a Labware when running a Python protocol, and AbstractLabware when running a JSON protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a check to Python Protocol API v2's
.load_module()method to prevent you from loading a Heater-Shaker into slot 9, because it would conflict with the fixed trash in "slot" 12.Closes #10912.
Review requests
_get_adjacent_locations()and friends to make sure I'm correctly preserving their existing behavior.# TODOcomment somewhere for mirroring this logic in PAPIv3 or Protocol Engine?Risk assessment
Low.
This change involved refactoring some unrelated deck conflict-checking code, so there is some risk of causing
load_module()orload_labware()to either wrongly fail to report a conflict or wrongly report a nonexistent conflict. But this module seems covered well by unit and integration tests.