Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for /runs endpoints #10314

Closed
mattwelch opened this issue May 17, 2022 · 0 comments · Fixed by #10323
Closed

Add acceptance tests for /runs endpoints #10314

mattwelch opened this issue May 17, 2022 · 0 comments · Fixed by #10323
Assignees
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@mattwelch
Copy link

mattwelch commented May 17, 2022

#10187 left the tests for robot-server's /runs endpoints in a state of partial overlap. The files that test that resources persist across reboots are also, partially, testing that those resources are correct. This ticket is to split things up to give each test file a clearer job.

Acceptance criteria

For the /runs endpoints:

  • Tavern tests should cover the bulk of behavior. In particular, they assert that the response bodies are semantically correct.
  • The non-Tavern persistence tests should only cover persistence. They should rely on other tests to make sure the server is persisting the correct things.
@mattwelch mattwelch added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants