fix(app-testing): snapshot failure capture (#15425)

Opentrons · Jun 14, 2024 · f0e1917 · f0e1917
1 parent de5b66f
commit f0e1917
Show file tree

Hide file tree

Showing 39 changed files with 897 additions and 1,335 deletions.
diff --git a/...test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json b/...test_analysis_snapshot[041ad55e7b][OT2_S_v2_15_P300M_P20S_HS_TC_TM_dispense_changes].json
@@ -17,41 +17,37 @@
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Let there be light! True 🌠🌠🌠",
- "legacyCommandType": "command.COMMENT"
+ "message": "Let there be light! True 🌠🌠🌠"
  },
  "result": {},
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Is the door is closed? True 🚪🚪🚪",
- "legacyCommandType": "command.COMMENT"
+ "message": "Is the door is closed? True 🚪🚪🚪"
  },
  "result": {},
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Is this a simulation? True 🔮🔮🔮",
- "legacyCommandType": "command.COMMENT"
+ "message": "Is this a simulation? True 🔮🔮🔮"
  },
  "result": {},
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Running against API Version: 2.15",
- "legacyCommandType": "command.COMMENT"
+ "message": "Running against API Version: 2.15"
  },
  "result": {},
  "status": "succeeded"

diff --git a/...73][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json b/...73][Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum].json
@@ -21,7 +21,7 @@
  "errorInfo": {
  "args": "(\"Maximum is type 'str', but must be of parameter type 'int'\",)",
  "class": "ParameterDefinitionError",
- "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"<string>\", line 1, in <module>\n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 199, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 94, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n"
+ "traceback": " File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/execution/execute_python.py\", line 80, in _parse_and_set_parameters\n exec(\"add_parameters(__param_context)\", new_globs)\n\n File \"<string>\", line 1, in <module>\n\n File \"Flex_X_v2_18_NO_PIPETTES_Overrides_BadTypesInRTP_Override_wrong_type_in_maximum.py\", line 104, in add_parameters\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocol_api/_parameter_context.py\", line 61, in add_int\n parameter = parameter_definition.create_int_parameter(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 200, in create_int_parameter\n return ParameterDefinition(\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/parameter_definition.py\", line 95, in __init__\n validation.validate_options(default, minimum, maximum, choices, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 266, in validate_options\n _validate_min_and_max(minimum, maximum, parameter_type)\n\n File \"/usr/local/lib/python3.10/site-packages/opentrons/protocols/parameters/validation.py\", line 218, in _validate_min_and_max\n raise ParameterDefinitionError(\n"
  },
  "errorType": "PythonException",
  "isDefined": false,

diff --git a/...test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json b/...test/test_analysis_snapshot[0c4ae179bb][OT2_S_v2_15_P300M_P20S_HS_TC_TM_SmokeTestV3].json
@@ -17,41 +17,37 @@
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Let there be light! True 🌠🌠🌠",
- "legacyCommandType": "command.COMMENT"
+ "message": "Let there be light! True 🌠🌠🌠"
  },
  "result": {},
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Is the door is closed? True 🚪🚪🚪",
- "legacyCommandType": "command.COMMENT"
+ "message": "Is the door is closed? True 🚪🚪🚪"
  },
  "result": {},
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Is this a simulation? True 🔮🔮🔮",
- "legacyCommandType": "command.COMMENT"
+ "message": "Is this a simulation? True 🔮🔮🔮"
  },
  "result": {},
  "status": "succeeded"
  },
  {
- "commandType": "custom",
+ "commandType": "comment",
  "notes": [],
  "params": {
- "legacyCommandText": "Running against API Version: 2.15",
- "legacyCommandType": "command.COMMENT"
+ "message": "Running against API Version: 2.15"
  },
  "result": {},
  "status": "succeeded"