Skip to content

Commit

Permalink
fix(shared-data) Update tip overlap values for Flex Pipettes (#15147)
Browse files Browse the repository at this point in the history
<!--
Thanks for taking the time to open a pull request! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
After conducting hardware testing, we've formulated updated tip overlap
values for every tip size and pipette model. These adjustments apply to
1-channel, 8-channel, and 96-channel pipettes. These revised values aim
to mitigate overpressure occurrences in ABR.


[https://docs.google.com/spreadsheets/d/16dEmqulO4SIKU6E0aYTfVQEnZRTn3MwNF_WB8K1KmRM/edit#gid=0](url)


<!--
Use this section to describe your pull-request at a high level. If the
PR addresses any open issues, please tag the issues here.
-->

# Test Plan
None
<!--
Use this section to describe the steps that you took to test your Pull
Request.
If you did not perform any testing provide justification why.

OT-3 Developers: You should default to testing on actual physical
hardware.
Once again, if you did not perform testing against hardware, justify
why.

Note: It can be helpful to write a test plan before doing development

Example Test Plan (HTTP API Change)

- Verified that new optional argument `dance-party` causes the robot to
flash its lights, move the pipettes,
then home.
- Verified that when you omit the `dance-party` option the robot homes
normally
- Added protocol that uses `dance-party` argument to G-Code Testing
Suite
- Ran protocol that did not use `dance-party` argument and everything
was successful
- Added unit tests to validate that changes to pydantic model are
correct

-->

# Changelog
### **Pipette shared data**
### P1KS Single Channel
- Updated V3_5 Tip Overlap values for 50uL, 200uL, and 1000uL tips.
- Updated V3_6 Tip Overlap values for 50uL 200uL, and 1000uL tips.
### P50S Single Channel Pipette
- Updated V3_5 Tip Overlap values for 50uL, 200uL, and 1000uL tips.
- Updated V3_6 Tip Overlap values for 50uL 200uL, and 1000uL tips.
### P1KM 8 Channel Pipette
- Updated V3_5 Tip Overlap values for 50uL, 200uL, and 1000uL tips.
- Updated V3_6 Tip Overlap values for 50uL 200uL, and 1000uL tips.
### P50M 8 Channel Pipette
- Updated V3_5 Tip Overlap values for 50uL, 200uL, and 1000uL tips.
- Updated V3_6 Tip Overlap values for 50uL 200uL, and 1000uL tips
### P1H 95-Channel Pipette
- Updated V3_5 Tip Overlap values for 50uL, 200uL, and 1000uL tips.
- Updated V3_6 Tip Overlap values for 50uL 200uL, and 1000uL tips

<!--
List out the changes to the code in this PR. Please try your best to
categorize your changes and describe what has changed and why.

Example changelog:
- Fixed app crash when trying to calibrate an illegal pipette
- Added state to API to track pipette usage
- Updated API docs to mention only two pipettes are supported

IMPORTANT: MAKE SURE ANY BREAKING CHANGES ARE PROPERLY COMMUNICATED
-->

# Review requests

<!--
Describe any requests for your reviewers here.
-->

# Risk assessment
Low
<!--
Carefully go over your pull request and look at the other parts of the
codebase it may affect. Look for the possibility, even if you think it's
small, that your change may affect some other part of the system - for
instance, changing return tip behavior in protocol may also change the
behavior of labware calibration.

Identify the other parts of the system your codebase may affect, so that
in addition to your own review and testing, other people who may not
have the system internalized as much as you can focus their attention
and testing there.
-->

---------

Co-authored-by: Seth Foster <[email protected]>
  • Loading branch information
Carlos-fernandez and sfoster1 committed May 10, 2024
1 parent 0c40f7d commit 0096c12
Show file tree
Hide file tree
Showing 22 changed files with 75 additions and 6,047 deletions.
5,968 changes: 0 additions & 5,968 deletions shared-data/js/__tests__/__snapshots__/pipettes.test.ts.snap

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions shared-data/js/__tests__/pipettes.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ describe('pipette data accessors', () => {
'#/pipette/schemas/2/pipetteLiquidPropertiesSchema.json',
defaultTipOverlapDictionary: {
default: 10.5,
'opentrons/opentrons_flex_96_tiprack_1000ul/1': 10.5,
'opentrons/opentrons_flex_96_tiprack_200ul/1': 10.5,
'opentrons/opentrons_flex_96_tiprack_50ul/1': 10.5,
'opentrons/opentrons_flex_96_filtertiprack_1000ul/1': 10.5,
'opentrons/opentrons_flex_96_filtertiprack_200ul/1': 10.5,
'opentrons/opentrons_flex_96_filtertiprack_50ul/1': 10.5,
'opentrons/opentrons_flex_96_tiprack_1000ul/1': 9.65,
'opentrons/opentrons_flex_96_tiprack_200ul/1': 9.76,
'opentrons/opentrons_flex_96_tiprack_50ul/1': 10.09,
'opentrons/opentrons_flex_96_filtertiprack_1000ul/1': 9.65,
'opentrons/opentrons_flex_96_filtertiprack_200ul/1': 9.76,
'opentrons/opentrons_flex_96_filtertiprack_50ul/1': 10.09,
},
defaultTipracks: [
'opentrons/opentrons_flex_96_tiprack_1000ul/1',
Expand Down Expand Up @@ -150,8 +150,8 @@ describe('pipette data accessors', () => {
$otSharedSchema: '#/pipette/schemas/2/pipetteLiquidPropertiesSchema.json',
defaultTipOverlapDictionary: {
default: 10.5,
[tiprackFilter50uL]: 10.5,
[tiprack50uL]: 10.5,
[tiprackFilter50uL]: 10.09,
[tiprack50uL]: 10.09,
},
defaultTipracks: [tiprack50uL, tiprackFilter50uL],
maxVolume: 50,
Expand Down Expand Up @@ -198,8 +198,8 @@ describe('pipette data accessors', () => {
$otSharedSchema: '#/pipette/schemas/2/pipetteLiquidPropertiesSchema.json',
defaultTipOverlapDictionary: {
default: 10.5,
[tiprackFilter50uL]: 10.5,
[tiprack50uL]: 10.5,
[tiprackFilter50uL]: 10.09,
[tiprack50uL]: 10.09,
},
defaultTipracks: [tiprack50uL, tiprackFilter50uL],
maxVolume: 30,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`test createIrregularLabware function > failing to validate against labware schema throws w/o "strict" 1`] = `[Error: Generated labware failed to validate, please check your inputs]`;

exports[`test createIrregularLabware function failing to validate against labware schema throws w/o "strict" 1`] = `"Generated labware failed to validate, please check your inputs"`;
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`createLabware > failing to validate against labware schema throws w/o "strict" 1`] = `[Error: Generated labware failed to validate, please check your inputs]`;

exports[`createLabware failing to validate against labware schema throws w/o "strict" 1`] = `"Generated labware failed to validate, please check your inputs"`;
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.17,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.17
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.67,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.67
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.17,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.1,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.17
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.67,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.42,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.67
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.05,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.05
"opentrons/opentrons_flex_96_tiprack_50ul/1": 9.53,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 9.53
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.16,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.16
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.16,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.74,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.16
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.16,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.21,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.74
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_tiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_1000ul/1": 9.65,
"opentrons/opentrons_flex_96_filtertiprack_200ul/1": 9.76,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 1000,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 50,
"minVolume": 5,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 30,
"minVolume": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@
},
"defaultTipOverlapDictionary": {
"default": 10.5,
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.5,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.5
"opentrons/opentrons_flex_96_tiprack_50ul/1": 10.09,
"opentrons/opentrons_flex_96_filtertiprack_50ul/1": 10.09
},
"maxVolume": 30,
"minVolume": 1,
Expand Down

0 comments on commit 0096c12

Please sign in to comment.