Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'senders' and 'received-auth' in 'listen on socket' #779

Closed
wants to merge 3 commits into from

Conversation

Wolf480pl
Copy link
Contributor

A proof-of-concept implementation of #709

  • make the lookup process offer a uid to userinfo lookup by means of IMSG_SMTP_LOOKUP_UID_USERINFO
    (I wasn't sure if this should go through a table or not, so chose the simpler option for now)
  • add an optional username argument to smtp_session
  • use the uid received by smtp process in IMSG_CTL_SMTP_SESSION
    to find the user's username, and pass it to the smtp_session
  • respect the F_RECEIVEDAUTH flag whenever a user is authenticated,
    even if the connection is not SF_SECURE
  • allow using received-auth and senders in listen on socket in the config

Wolf480pl and others added 3 commits April 30, 2017 16:31
- make the lookup process offer a uid to userinfo lookup by
  means of IMSG_SMTP_LOOKUP_UID_USERINFO
- add an optional username argument to smtp_session
- use the uid received by smtp process in IMSG_CTL_SMTP_SESSION
  to find the user's username, and pass it to the smtp_session
- respect the F_RECEIVEDAUTH flag whenever a user is authenticated,
  even if the connection is not SF_SECURE
@poolpOrg
Copy link
Member

The feature request still exists but the PR was not acceptable back then and no longer applies, I'll close it and see if I can implement that differently.

For a back story, a lengthy discussion between @ericfaurot and I happened with regard to socket listeners, how they were implemented and how they should be implemented, a bit of the discussion provides insight on why your PR required special handling with regard to a network listener.

I'll tackle your feature request when we refactor a bit "listen on socket"

@poolpOrg poolpOrg closed this Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants