Add 'ec-ecparam.softhsm' test #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrichb
force-pushed
the
add_ecparam_test
branch
from
2aa7a24
to
be5f7d0
Compare
|
It needs |
|
Ooops, committed it under Windows. Fixed. |
|
... now they run and - yipee - the |
|
Thank you. This test will be very useful for fixing it and and for finding any future regressions. |
mtrojnar
added a commit
that referenced
this pull request
Aug 13, 2022
This test only works on OpenSSL 1.1.1, because while `openssl ecparam` opens the engine specified in the `-engine` parameter, it never uses the engine for actual key generation. This bug in OpenSSL 1.1.1 can be easily confirmed with: ```sh $ openssl version OpenSSL 1.1.1n 15 Mar 2022 $ pkcs11-tool --list-token-slots Available slots: No slots. $ openssl ecparam -engine pkcs11 -name prime256v1 -genkey -out ec_key.pem engine "pkcs11" set. $ cat ec_key.pem -----BEGIN EC PARAMETERS----- BggqhkjOPQMBBw== -----END EC PARAMETERS----- -----BEGIN EC PRIVATE KEY----- MHcCAQEEILV/lcPsKV8J37hOf7nMmT9FBgync4fLx73HkH+STektoAoGCCqGSM49 AwEHoUQDQgAE5+qQeMjnQNZJrkB1RuwjDgvpTec2diaQR94K2xIy+aqawRFCUnCn 5HXHrIwCMtpb7LwRikA8tuQxtSKfPIILXw== -----END EC PRIVATE KEY----- ``` Generating a key on an engine and saving the private key to a file is *not* a functionality that we want to support. It's easier, faster and more secure to generate the key pair in software instead. This reverts commit 5c5e2b6 (#465).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional test for #456.
It runs
openssl ecparam -genkey ...with an additional-engine pkcs11.The test passes after @dengert's fixes for #456 (commit 5ab3c0d) ... but not on the current master.
The commit which breaks the test is feb22a6. When reverting this commit on the current master the test becomes green (and all other are green too).