Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CardOS 5.3 cards have different ATR so they are not picked up by OpenSC at this moment. Unless there will be more differences in the future, using some ATR mask would probably make sense.
These cards also present ODF with non-strict encoded ASN1:
Note the length part
81 25
combining into the length of 37, which is not handled by current code (expecting the length of the "length" to be only single byte).Further changes to incorporate the support of the CardOS 5.3 might be needed, but so far submitting what we have so far.