Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial CardOS 5.3 support #947

Merged
merged 2 commits into from
Jan 28, 2017
Merged

Conversation

Jakuje
Copy link
Member

@Jakuje Jakuje commented Jan 26, 2017

CardOS 5.3 cards have different ATR so they are not picked up by OpenSC at this moment. Unless there will be more differences in the future, using some ATR mask would probably make sense.

These cards also present ODF with non-strict encoded ASN1:

6F 81 25 83 02 50 31 82 01 01 80 02 00 3C 88 00 o.%..P1......<..
85 01 00 8A 01 05 AB 10 80 01 01 90 00 80 01 06 ................
A4 06 83 01 11 95 01 80 90 00                   ..........

Note the length part 81 25 combining into the length of 37, which is not handled by current code (expecting the length of the "length" to be only single byte).

Further changes to incorporate the support of the CardOS 5.3 might be needed, but so far submitting what we have so far.

@frankmorgner frankmorgner merged commit 92765f6 into OpenSC:master Jan 28, 2017
@Jakuje
Copy link
Member Author

Jakuje commented Jan 28, 2017

Thanks. It looks like we are not completely done here. The cards do not respond correctly to our sign/decode commands correctly. Hopefully next week I will be able to uncover this other part to make it working, which will need 5.3-specific changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants