add Japanese national card driver #801
Conversation
| return SC_ERROR_OUT_OF_MEMORY; | ||
| } | ||
| memset(drvdata, 0, sizeof (struct jpki_private_data)); | ||
| sc_format_path("D3 92 f0 00 26 01 00 00 00 01", &drvdata->aid); |
There was a problem hiding this comment.
You're selecting this AID multiple times. Could you use something like a define or a global const for this?
|
Could you rebase your PR into 1-2 commits? |
|
@viktorTarasov OK, I've rebase and force pushed into this branch. |
| #include <string.h> | ||
| #include <stdio.h> | ||
| #ifdef ENABLE_OPENSSL | ||
| #include <openssl/x509v3.h> |
There was a problem hiding this comment.
are you using this include?
|
@hamano Just little remark: Also, if in some function you have the FUNC_CALLED debug message call, it's better to insert also the FUNC_RETURN message. (without fanaticism, of cause). |
|
Thanks for your review. |
| LOG_TEST_RET(card->ctx, rc, "APDU transmit failed"); | ||
| if (apdu.sw1 != 0x63) { | ||
| sc_log(card->ctx, "VERIFY GET_INFO error"); | ||
| LOG_FUNC_RETURN(card->ctx, SC_ERROR_CARD_CMD_FAILED); |
There was a problem hiding this comment.
If your card is ISO 7816 compliant, then you should get 9000 when the user is logged with this APDU. In this case you should not return an error!
|
how have you tested your implementation? |
VTA: cosmetic touch and rebase to one commit close PR #801
|
applied in f80673e |
|
@frankmorgner I've tested pkcs11-tool -l -s and SSH login. |
|
@viktorTarasov please merge 83db4f1 9ed8537 9599d0c |
|
@viktorTarasov OK, Thanks!
Do you prefer to merge from another PR? |
|
@hamano Your card driver is in master, it cannot be rebased, and so, all changes have to pass through a dedicated PR. |
VTA: cosmetic touch and rebase to one commit close PR OpenSC#801
VTA: cosmetic touch and rebase to one commit close PR #801
VTA: cosmetic touch and rebase to one commit close PR OpenSC#801
VTA: cosmetic touch and rebase to one commit close PR OpenSC#801
Japan began to distribute national ID card from this year.
One of application called JPKI has two digital certificate.
I wrote driver for this card.
Thank you.